Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a public error-code classification utility to
jsonrpc-coreand aligns response-side validation and samples with that API.Main changes:
JsonRpcErrorClassifierfor semantic classification of integer JSON-RPCerror.codevaluesJsonRpcErrorCodeCategorywith:STANDARDSERVER_RESERVED_RANGECUSTOMDefaultJsonRpcErrorClassifieras the default implementationDefaultJsonRpcResponseValidatorto reuse the classifier for:STANDARD_ONLYSTANDARD_OR_SERVER_ERROR_RANGECUSTOM_RANGEas a direct numeric bounds check, independent of classifier categorySTANDARD_ONLYrejection for custom codesRelated Issues
Change Type
JSON-RPC Impact
Describe protocol-level impact, if any:
Details:
error.codevalues.CUSTOM_RANGEstill validates against configured numeric bounds rather than classifier category.CUSTOMclassification does not mean invalid; it means the code is outside the standard set and the reserved server range.Validation
./gradlew test./gradlew checkAdditional verification performed:
./gradlew :jsonrpc-core:test --tests 'com.limehee.jsonrpc.core.DefaultJsonRpcErrorClassifierTest' --tests 'com.limehee.jsonrpc.core.DefaultJsonRpcResponseValidatorTest' --no-daemon./gradlew -p samples/pure-java-demo test --no-daemonDocumentation
Notes: