Skip to content

More lenient parsing of glyph points#392

Merged
cmyr merged 1 commit intomasterfrom
relax-point-parsing
Mar 16, 2026
Merged

More lenient parsing of glyph points#392
cmyr merged 1 commit intomasterfrom
relax-point-parsing

Conversation

@cmyr
Copy link
Member

@cmyr cmyr commented Mar 14, 2026

Specifically if an off-curve point has the 'smooth' attribute set, we will now log a warning instead of returning an error.

closes #391

/// Has an unexpected move definition.
UnexpectedMove,
/// Has an unexpected smooth definition.
//TODO: no longer used, can be removed next non-patch release
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe stick a #[deprecated(since = "new-ver", note = "will no longer be produced, scheduled for removal")] on this in the interim?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!

@cmyr cmyr force-pushed the relax-point-parsing branch 2 times, most recently from f18191b to 294c504 Compare March 16, 2026 14:29
Specifically if an off-curve point has the 'smooth' attribute set, we
will now log a warning instead of returning an error.
@cmyr cmyr force-pushed the relax-point-parsing branch from 294c504 to ad1ad85 Compare March 16, 2026 14:46
@cmyr cmyr merged commit a8f9b2f into master Mar 16, 2026
5 checks passed
@cmyr cmyr deleted the relax-point-parsing branch March 16, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

should smooth="yes" on off-curve points be a warning instead of an error?

3 participants