Add Cluster-Level Instance Operation Count Metrics#58
Merged
LZD-PratyushBhatt merged 3 commits intodevfrom Oct 27, 2025
Merged
Conversation
| _totalPastDueMsgSize.set(totalPastDueMsgSize); | ||
|
|
||
| // Count instances by operation type (cluster-level metrics) | ||
| long enableCount = 0; |
Collaborator
There was a problem hiding this comment.
create a map of perOperationInstanceCount. Then do
long count = perOperationInstanceCount.get(config.getInstanceOperation().getOperation())
perOperationInstanceCount.put(config.getInstanceOperation().getOperation(), count+1)
From the getInstancesInOperationEnableGauge return perOperationInstanceCount[ENABLE]
| if (instanceConfigMap != null) { | ||
| for (Map.Entry<String, InstanceConfig> entry : instanceConfigMap.entrySet()) { | ||
| InstanceConfig config = entry.getValue(); | ||
| InstanceConstants.InstanceOperation operation; |
Collaborator
There was a problem hiding this comment.
nit: set the instance operation to ENABLE here, that way you won't require to add the else block
proud-parselmouth
approved these changes
Oct 27, 2025
Collaborator
proud-parselmouth
left a comment
proud-parselmouth
left a comment
There was a problem hiding this comment.
LGTM. Added a nit comment.
ashiijo
pushed a commit
that referenced
this pull request
Oct 30, 2025
* Add Cluster-Level Instance Operation Count Metrics * Address review comments * Address review comments3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
This PR adds cluster-level metrics to count how many instances are currently in each Instance Operation state.
(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description
(Write a concise description including what, why, how)
This Change introduces cluster-wide metrics to count instances in each Instance Operation state (ENABLE, DISABLE, EVACUATE, SWAP_IN, UNKNOWN).
Metrics exposed (cluster-level):
Tests
testClusterLevelInstanceOperationCounts
Manually tested with real Helix Cluster, works fine!
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)