Update Ideal State API creating new Ideal State #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
apache#3077
Description
(Write a concise description including what, why, how)
We are observing this issue when the resource gets deleted midway by customer scripts after (!_zkClient.exists(zkPath)) check and another process is trying to update the deleted resource's idealstate. The resource gets created with just the updated parameters in the API payload.
This can lead to rebalance failure as well when the updated parameters does not contain the num of partitions. Rebalancer considers num_partition for this resource as -1 leading to rebalance failure.
Tests
Unit Tests added
Verified the API changes locally.