Simplify InstanceMonitor metric reset to eliminate thread overhead#78
Merged
LZD-PratyushBhatt merged 1 commit intorelease-1.4.7-dev-202511211100from Nov 21, 2025
Merged
Conversation
laxman-ch
approved these changes
Nov 21, 2025
6d0c5b9
into
release-1.4.7-dev-202511211100
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Simplify InstanceMonitor metric reset to eliminate thread overhead
(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
Description
(Write a concise description including what, why, how)
Removed the delayed gauge-reset mechanism that previously created per-instance threads. Earlier, whenever an instance’s operation changed, the system scheduled a background task to reset other operation gauges after a 2-minute delay. In clusters with ~10,000 instances, this resulted in excessive thread creation and contributed to OutOfMemoryError conditions due to hitting thread limits.
The new implementation performs all non-current operation gauge resets immediately and synchronously when an operation change is detected. This removes all thread creation, delayed tasks, and executor-management overhead while preserving the intended behavior of tracking per-instance operation durations.
Only the currently active operation gauge will show a non-zero duration. When an operation changes, all other operation gauges are reset to zero instantly, and the new operation begins timing from its start
Tests
Manually tested + UTs
(List the names of added unit/integration tests)
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)