Invert Traffic Split and EmojiVoto Creation#1916
Open
GTRekter wants to merge 5 commits intolinkerd:mainfrom
Open
Invert Traffic Split and EmojiVoto Creation#1916GTRekter wants to merge 5 commits intolinkerd:mainfrom
GTRekter wants to merge 5 commits intolinkerd:mainfrom
Conversation
GTRekter
force-pushed
the
ivanp/trafficsplit
branch
2 times, most recently
from
5a471e9 to
7b6d0ad
Compare
Signed-off-by: Flynn <flynn@buoyant.io> Signed-off-by: Ivan Porta <gtrekter@Mac.wind3.hub>
Signed-off-by: Joe Fuller <joe@buoyant.io> Signed-off-by: Ivan Porta <gtrekter@Mac.wind3.hub>
GTRekter
force-pushed
the
ivanp/trafficsplit
branch
from
8653f43 to
6a63f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invert the order in which TrafficSplit and Emojivoto are created, and add a warning about the importance of this order. Also, mention that if the ServiceProfile is created after the pod has already started, the workloads will need to be restarted.