Skip to content

Configure default Python version using integration-tests job environment #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgarber-akamai merged 2 commits into from
Nov 12, 2024
Merged

Configure default Python version using integration-tests job environment #473

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
659a28d
Configure default Python version using workflow environment
lgarber-akamai Nov 12, 2024
0e8435f
Correct EOL and default Python versions
lgarber-akamai Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ on:
python-version:
description: 'Specify Python version to use'
required: false
default: '3.10'
run-eol-python-version:
description: 'Run EOL python version?'
required: false
Expand All @@ -28,11 +27,14 @@ on:
- main
- dev

env:
DEFAULT_PYTHON_VERSION: "3.10"
EOL_PYTHON_VERSION: "3.9"
Copy link
Copy Markdown
Contributor

@yec-akamai yec-akamai Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems 3.9 is not officially EOL now. Is it okay to leave it as it is?

Copy link
Copy Markdown
Contributor Author

@lgarber-akamai lgarber-akamai Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! I just pushed up a commit with the adjusted versions; this probably needs to be applied to the other Python repos too 👍

EXIT_STATUS: 0

jobs:
integration-tests:
runs-on: ubuntu-latest
env:
EXIT_STATUS: 0
steps:
- name: Clone Repository with SHA
if: ${{ inputs.sha != '' }}
Expand All @@ -52,7 +54,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: ${{ inputs.run-eol-python-version == 'true' && '3.9' || inputs.python-version }}
python-version: ${{ inputs.run-eol-python-version == 'true' && env.EOL_PYTHON_VERSION || inputs.python-version || env.DEFAULT_PYTHON_VERSION }}

- name: Install Python deps
run: pip install -U setuptools wheel boto3 certifi
Expand Down