Fix LinodeInterfaceUpdateOptions
#825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
Copilot,
jriddle-linode and
yec-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a dedicated VPCInterfaceUpdateOptions struct to handle VPC interface updates without the subnet_id field that cannot be updated, and removes VLAN interface update support.
- Creates new
VPCInterfaceUpdateOptionstype without thesubnet_idfield - Updates
LinodeInterfaceUpdateOptionsto use the new VPC update options and removes VLAN field - Updates test to use the new
VPCInterfaceUpdateOptionstype
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| interfaces.go | Adds VPCInterfaceUpdateOptions struct and updates LinodeInterfaceUpdateOptions to use it while removing VLAN support |
| test/unit/interface_test.go | Updates test to use new VPCInterfaceUpdateOptions type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zliang-akamai
changed the title
VPCInterfaceUpdateOptionsLinodeInterfaceUpdateOptions
lgarber-akamai
approved these changes
Sep 15, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Thanks for the fix!
srbhaakamai
pushed a commit
to srbhaakamai/linodego
that referenced
this pull request
Oct 4, 2025
srbhaakamai
pushed a commit
to srbhaakamai/linodego
that referenced
this pull request
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
subnet_idcannot be updated, but it always appears in requests built withVPCInterfaceCreateOptions. To address this, create a dedicated VPCInterfaceUpdateOptions for updates.