refactor: [M3-8127] - Query Key Factory for Domains#10559
Merged
bnussman-akamai merged 2 commits intolinode:developfrom Jun 11, 2024
Merged
refactor: [M3-8127] - Query Key Factory for Domains#10559bnussman-akamai merged 2 commits intolinode:developfrom
bnussman-akamai merged 2 commits intolinode:developfrom
Conversation
bnussman-akamai
added
the
React Query
bnussman-akamai
requested review from
abailly-akamai and
hkhalil-akamai
and removed request for
a team
hkhalil-akamai
approved these changes
Jun 10, 2024
Contributor
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
There was a problem hiding this comment.
✅ Tested creating, viewing, editing and deleting domains and verified changes are reflected in a parallel browser window.
abailly-akamai
approved these changes
Jun 11, 2024
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Code looks good and noticed no regression while testing adding, editing, deleting domains ✅
|
Coverage Report: ✅ |
This was referenced Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
Note
No UI changes expected
How to test 🧪
As an Author I have considered 🤔