test: Improve disk encryption banner test in CI#10572
Merged
jdamore-linode merged 1 commit intolinode:developfrom Jun 13, 2024
Merged
Conversation
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Jun 12, 2024
hana-akamai
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This tweaks our new LKE disk encryption banner tests to be more resilient to differences between our development accounts and our CI test accounts. Specifically, our CI test accounts often don't have LKE clusters, so I added mocks so that the tests continue to pass when this is the case.
I don't think a changelog entry is necessary here since these tests have not been included in a release yet.
Changes 🔄
How to test 🧪
We can rely on the automated tests for this since they're currently failing consistently, but you can also run the test locally if you want to check it out:
yarn cy:run -s "cypress/e2e/core/kubernetes/lke-landing-page.spec.ts"As an Author I have considered 🤔
Check all that apply