Skip to content

test: Improve disk encryption banner test in CI#10572

Merged
jdamore-linode merged 1 commit intolinode:developfrom
jdamore-linode:improve-lke-disk-encryption-banner-tests-ci
Jun 13, 2024
Merged

test: Improve disk encryption banner test in CI#10572
jdamore-linode merged 1 commit intolinode:developfrom
jdamore-linode:improve-lke-disk-encryption-banner-tests-ci

Conversation

@jdamore-linode
Copy link
Contributor

Description 📝

This tweaks our new LKE disk encryption banner tests to be more resilient to differences between our development accounts and our CI test accounts. Specifically, our CI test accounts often don't have LKE clusters, so I added mocks so that the tests continue to pass when this is the case.

I don't think a changelog entry is necessary here since these tests have not been included in a release yet.

Changes 🔄

  • Mock clusters for both LKE landing page disk encryption banner tests

How to test 🧪

We can rely on the automated tests for this since they're currently failing consistently, but you can also run the test locally if you want to check it out:

yarn cy:run -s "cypress/e2e/core/kubernetes/lke-landing-page.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode self-assigned this Jun 12, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner June 12, 2024 16:58
@jdamore-linode jdamore-linode requested review from a team, carrillo-erik, cliu-akamai and hana-akamai and removed request for a team June 12, 2024 16:58
@github-actions
Copy link

Coverage Report:
Base Coverage: 82.76%
Current Coverage: 82.76%

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Jun 12, 2024
@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jun 13, 2024
@jdamore-linode jdamore-linode merged commit 2db9ca3 into linode:develop Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Ready for Review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants