Skip to content

fix: [M3-8193] - Check account access for disabling add tags button#10583

Merged
jaalah-akamai merged 2 commits intolinode:developfrom
jaalah-akamai:M3-8193
Jun 20, 2024
Merged

fix: [M3-8193] - Check account access for disabling add tags button#10583
jaalah-akamai merged 2 commits intolinode:developfrom
jaalah-akamai:M3-8193

Conversation

@jaalah-akamai
Copy link
Contributor

Description 📝

Attempting to add a tag to the Linode would give the "" already added error, even if no text is entered or no tag has been applied. This is because a User must be an unrestricted User in order to add or modify tags on Linodes. This is actually explicitly mentioned in the API docs

Changes 🔄

  • Added account access grant check
  • Added disabled tooltip text
  • Added unit test

Target release date 🗓️

Next release

Preview 📷

Before After
Screenshot 2024-06-14 at 10 23 05 AM Screenshot 2024-06-14 at 9 40 15 AM

How to test 🧪

Prerequisites

(How to setup test environment)

  • Have a restricted user account with R/W access to a Linode, but Billing Access set to none.

Reproduction steps

(How to reproduce the issue, if applicable)

  • Go to the linodes detail page and try adding a tag
  • Observe the issue in the before screenshot

Verification steps

(How to verify changes)

  • Checkout branch and follow same reproduction steps
  • Observe button is now disabled with tooltip text

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jaalah-akamai jaalah-akamai added the Bug Fixes for regressions or bugs label Jun 14, 2024
@jaalah-akamai jaalah-akamai self-assigned this Jun 14, 2024
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner June 14, 2024 14:25
@jaalah-akamai jaalah-akamai requested review from cpathipa and dwiley-akamai and removed request for a team June 14, 2024 14:25
@github-actions
Copy link

github-actions bot commented Jun 14, 2024

Coverage Report:
Base Coverage: 82.8%
Current Coverage: 82.81%

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming on the tooltip for restricted user.
image

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed "Add a Tag" button is disabled on Linode Details page for restricted user matching the specified criteria ✅

Did not observe any adverse impacts on other TagCell instances in app ✅

Code review ✅

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Jun 18, 2024
@jaalah-akamai jaalah-akamai merged commit 2d416b8 into linode:develop Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants