fix: [M3-8193] - Check account access for disabling add tags button#10583
Merged
jaalah-akamai merged 2 commits intolinode:developfrom Jun 20, 2024
Merged
fix: [M3-8193] - Check account access for disabling add tags button#10583jaalah-akamai merged 2 commits intolinode:developfrom
jaalah-akamai merged 2 commits intolinode:developfrom
Conversation
…r modify tags on Linodes
|
Coverage Report: ✅ |
dwiley-akamai
approved these changes
Jun 17, 2024
Contributor
dwiley-akamai
left a comment
There was a problem hiding this comment.
Confirmed "Add a Tag" button is disabled on Linode Details page for restricted user matching the specified criteria ✅
Did not observe any adverse impacts on other TagCell instances in app ✅
Code review ✅
This was referenced Jun 21, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
Attempting to add a tag to the Linode would give the
"" already addederror, even if no text is entered or no tag has been applied. This is because a User must be an unrestricted User in order to add or modify tags on Linodes. This is actually explicitly mentioned in the API docsChanges 🔄
Target release date 🗓️
Next release
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
none.Reproduction steps
(How to reproduce the issue, if applicable)
beforescreenshotVerification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply