fix: [M3-10435] - ImageSelect, UserData Bug Fixes#12638
Merged
jaalah-akamai merged 10 commits intolinode:developfrom Aug 20, 2025
Merged
fix: [M3-10435] - ImageSelect, UserData Bug Fixes#12638jaalah-akamai merged 10 commits intolinode:developfrom
jaalah-akamai merged 10 commits intolinode:developfrom
Conversation
Contributor
Author
|
Good to go! |
bnussman-akamai
approved these changes
Aug 11, 2025
mjac0bs
reviewed
Aug 13, 2025
packages/manager/src/features/Linodes/LinodeCreate/UserData/UserDataHeading.tsx
Outdated
Show resolved
Hide resolved
…erDataHeading.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Collaborator
Cloud Manager UI test results🎉 730 passing tests on test run #8 ↗︎
|
mjac0bs
approved these changes
Aug 19, 2025
This was referenced Aug 21, 2025
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR addresses a critical React anti-pattern where the ImageSelect component was calling onChange during the render phase, causing the error "Cannot update a component (UserData) while rendering a different component (ImageSelect)".

The fix moves the auto-selection logic to a useEffect hook to ensure state updates happen after rendering is complete.
Changes 🔄
useEffecthook to prevent React warnings about updating components during renderhasBorderto omitted props forStyledFlagScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
N/A
user-data.mov
How to test 🧪
Verification steps
/linodes/create/marketplacehasBordererror no longer occursUser Data, observe the new layout where the description is exposed. Tooltip has been removedAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅