Skip to content

fix: [M3-10456] - Routing refactor follow-up bugs#12666

Merged
abailly-akamai merged 5 commits intolinode:developfrom
abailly-akamai:M3-10456
Aug 12, 2025
Merged

fix: [M3-10456] - Routing refactor follow-up bugs#12666
abailly-akamai merged 5 commits intolinode:developfrom
abailly-akamai:M3-10456

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Aug 11, 2025

Description 📝

This PR implements a couple regressions resulting from the routing refactor merged recently: #12602

⚠️ These fixes are meant to go out at the same time as the PR mentioned above, meaning the bugs are not affecting production and this PR prevents them form affecting real users.
As a result, there is NO CHANGESET associated with this one

🗒️ There is a separate ticket (M3-10457) to handle the scroll restoration regression (#12602 (comment))

Changes 🔄

  • Ensure Lish is working as previously
  • Deprecate "/dashboard" linking from the Akamai Logo

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

8/26/2025

Preview 📷

These fixes are only avoiding regressions and should match the production behavior

How to test 🧪

Prerequisites

Verification steps

  • Go to a linode detail, use the action menu to to trigger the Lish console. Confirm it is rendering the right component in the popup window
  • Click on the Akamai Logo in the TopMenu and confirm it links to the landing page (either managed or linodes)
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai marked this pull request as ready for review August 11, 2025 10:20
@abailly-akamai abailly-akamai requested a review from a team as a code owner August 11, 2025 10:20
@abailly-akamai abailly-akamai requested review from hana-akamai and pmakode-akamai and removed request for a team August 11, 2025 10:20
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lish is working now!

Clicking on the topmenu still links to /dashboard
image

@abailly-akamai
Copy link
Contributor Author

@coliu-akamai oops had forgotten to push the last commit 🍰

all set

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ /dashboard link gone
✅ reconfirmed lish

looks good, thanks @abailly-akamai!

Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed Lish working as previously and no more /dashboard link 🔨

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 11, 2025
@hana-akamai hana-akamai added the Approved Multiple approvals and ready to merge! label Aug 11, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 3 failing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing702 Passing4 Skipped134m 1s

Details

Failing Tests
SpecTest
restricted-user-details-pages.spec.tsCloud Manager Cypress Tests→restricted user details pages » should disable action elements and buttons in the 'Linodes' details page
smoke-linode-landing-table.spec.tsCloud Manager Cypress Tests→linode landing checks » checks the landing page side menu items
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/account/restricted-user-details-pages.spec.ts,cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

@abailly-akamai abailly-akamai merged commit ab403b2 into linode:develop Aug 12, 2025
34 of 42 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs Routing Refactor 🚨 Urgent

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants