Skip to content

feat: [UIE-9078] - IAM RBAC: add the missing permission check for Linode CreateDiskDrawer#12667

Merged
jaalah-akamai merged 5 commits intolinode:developfrom
aaleksee-akamai:UIE-9078-fix-linodes-create-disk
Aug 15, 2025
Merged

feat: [UIE-9078] - IAM RBAC: add the missing permission check for Linode CreateDiskDrawer#12667
jaalah-akamai merged 5 commits intolinode:developfrom
aaleksee-akamai:UIE-9078-fix-linodes-create-disk

Conversation

@aaleksee-akamai
Copy link
Copy Markdown
Contributor

Description 📝

This PR fixes the missing IAM permission check.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add permission check for Create disk drawer
  • Update tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

August 26

How to test 🧪

Prerequisites

(How to setup test environment)

MSW or iam (restricted) + regular account to compare
Permissions to check:

Custom User Entity Permissions preset:

[
    "create_linode_disk", 
]

Verification steps

(How to verify changes)

  • Confirm the buttons/inputs are disabled according the grant model with IAM is off, and according to the RBAC model when IAM is on.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai requested a review from a team as a code owner August 11, 2025 10:56
@aaleksee-akamai aaleksee-akamai requested review from coliu-akamai and cpathipa and removed request for a team August 11, 2025 10:56
@aaleksee-akamai aaleksee-akamai self-assigned this Aug 11, 2025
@aaleksee-akamai aaleksee-akamai added Linodes Dealing with the Linodes section of the app IAM (Identity & Access Management) labels Aug 11, 2025
Copy link
Copy Markdown

@kwojtowiakamai kwojtowiakamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The Create Disk Drawer is correctly enabled/disabled based on the permissions/grants for the IAM and non-IAM users.

Copy link
Copy Markdown
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ checked create disk restricted and non restricted IAM users
✅ checked create disk using grant model

I ran the failing linode-storage.spec.ts tests and the resize/add a disk tests passed locally (delete disk has been having issues, so that's most likely unrelated)

thanks @aaleksee-akamai!

@coliu-akamai coliu-akamai changed the title feat: [UIE-9078] - IAM RBAC: add the missing permission check feat: [UIE-9078] - IAM RBAC: add the missing permission check for Linode CreateDiskDrawer Aug 12, 2025
@aaleksee-akamai aaleksee-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 13, 2025
@jaalah-akamai jaalah-akamai self-assigned this Aug 14, 2025
@jaalah-akamai jaalah-akamai requested review from jaalah-akamai and removed request for cpathipa August 14, 2025 15:05
Copy link
Copy Markdown
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed issue in DevCloud environment

Local Changes Verified for Restricted User "Add A Disk":
✅ Properly enabled with grant system (as expected via permissions)
✅ Properly disabled with IAM system (as expected without permissions)

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 14, 2025
@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 14, 2025
@linode-gh-bot
Copy link
Copy Markdown
Collaborator

Cloud Manager UI test results

🎉 719 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing719 Passing4 Skipped127m 46s

@jaalah-akamai jaalah-akamai merged commit 37605ed into linode:develop Aug 15, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! IAM (Identity & Access Management) Linodes Dealing with the Linodes section of the app

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants