fix: [M3-10458] - IAM incorrect tags permission on Linode details page#12674
Merged
bnussman-akamai merged 4 commits intolinode:developfrom Aug 12, 2025
Conversation
cpathipa
approved these changes
Aug 11, 2025
bill-akamai
requested changes
Aug 11, 2025
bill-akamai
approved these changes
Aug 11, 2025
Contributor
bill-akamai
left a comment
There was a problem hiding this comment.
Looks good! Steps verified as instructed and restricted-user-details-pages.spec.ts passed ✅
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/volumes/create-volume.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts" |
||||||||||||||||||||
abailly-akamai
approved these changes
Aug 12, 2025
Contributor
abailly-akamai
left a comment
There was a problem hiding this comment.
This looks right to me, thanks @bnussman-akamai
|
✅ The "Add Tags" button is correctly enabled/disabled based on the restricted/unrestricted for both IAM and non-IAM users. |
kwojtowiakamai
approved these changes
Aug 12, 2025
This was referenced Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
/v4/tagsis only available to unrestricted users, which means, after the mapping change mentioned above, we should now use theis_account_adminpermissionScope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Tests
restricted-user-details-pages.spec.tscypress testAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅