Skip to content

fix: [M3-10458] - IAM incorrect tags permission on Linode details page#12674

Merged
bnussman-akamai merged 4 commits intolinode:developfrom
bnussman-akamai:M3-10458-fix-linode-tags-footer-permissions
Aug 12, 2025
Merged

fix: [M3-10458] - IAM incorrect tags permission on Linode details page#12674
bnussman-akamai merged 4 commits intolinode:developfrom
bnussman-akamai:M3-10458-fix-linode-tags-footer-permissions

Conversation

@bnussman-akamai
Copy link
Copy Markdown
Member

@bnussman-akamai bnussman-akamai commented Aug 11, 2025

Description 📝

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
Screenshot 2025-08-11 at 1 34 32 PM Screenshot 2025-08-11 at 1 34 48 PM
The Add Tag button is enabled but it should be disabled because my user is restricted The add tag button is correctly disabled for my restricted user

How to test 🧪

Prerequisites

  • Have a Linode on your account
  • Have two users on your account
    • A main unrestricted user
    • A restricted user with read-only billing (aka account) access and read-write permission on the Linode

Verification steps

  • As the restricted user, go to the Linode's details page
  • Confirm that the "Add Tags" button is disabled

Tests

  • Verify that this fixes the restricted-user-details-pages.spec.ts cypress test
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Copy link
Copy Markdown
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming restricted-user-details-pages.spec.ts cypress test passed in local.
image

Copy link
Copy Markdown
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a failing test in src/features/Linodes/LinodeEntityDetailFooter.test.tsx:

LinodeEntityDetailFooter > should enable "Add a tag" button if the user has update_account permission

@github-project-automation github-project-automation bot moved this from Review to Changes Requested in Cloud Manager Aug 11, 2025
Copy link
Copy Markdown
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Steps verified as instructed and restricted-user-details-pages.spec.ts passed ✅

@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in Cloud Manager Aug 11, 2025
@linode-gh-bot
Copy link
Copy Markdown
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing700 Passing7 Skipped137m 35s

Details

Failing Tests
SpecTest
create-volume.spec.tsCloud Manager Cypress Tests→volume create flow » "before all" hook for "creates an unattached volume"
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/volumes/create-volume.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

Copy link
Copy Markdown
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me, thanks @bnussman-akamai

@kwojtowiakamai
Copy link
Copy Markdown

✅ The "Add Tags" button is correctly enabled/disabled based on the restricted/unrestricted for both IAM and non-IAM users.

@bnussman-akamai bnussman-akamai merged commit e18cc8b into linode:develop Aug 12, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants