Skip to content

feat: [UIE-9076, UIE-9076] - IAM RBAC: fix permission check for rebuilding and resizing linode #12680

Merged
jaalah-akamai merged 6 commits intolinode:developfrom
aaleksee-akamai:UIE-9076-fix-linodes-menu-permissions
Aug 15, 2025
Merged

feat: [UIE-9076, UIE-9076] - IAM RBAC: fix permission check for rebuilding and resizing linode #12680
jaalah-akamai merged 6 commits intolinode:developfrom
aaleksee-akamai:UIE-9076-fix-linodes-menu-permissions

Conversation

@aaleksee-akamai
Copy link
Contributor

Description 📝

This PR fixes the missing IAM permission checks for rebuilding and resizing linodes in the drawers

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add permission check for rebuild linode drawer
  • Add permission check for resize linode drawer
  • Update tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

August 26

How to test 🧪

Prerequisites

(How to setup test environment)

MSW or iam (restricted) + regular account to compare
Permissions to check:

Custom User Entity Permissions preset:

[
    "resize_linode",
    "rebuild_linode"
]

Verification steps

(How to verify changes)

  • Confirm the buttons/inputs are disabled according the grant model with IAM is off, and according to the RBAC model when IAM is on.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai requested a review from a team as a code owner August 12, 2025 11:39
@aaleksee-akamai aaleksee-akamai requested review from bnussman-akamai and harsh-akamai and removed request for a team August 12, 2025 11:39
@aaleksee-akamai aaleksee-akamai self-assigned this Aug 12, 2025
@aaleksee-akamai aaleksee-akamai added Linodes Dealing with the Linodes section of the app IAM (Identity & Access Management) labels Aug 12, 2025
Copy link

@kwojtowiakamai kwojtowiakamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Add permission check for rebuild linode drawer.
✅ Add permission check for resize linode drawer.

@coliu-akamai coliu-akamai self-requested a review August 14, 2025 15:00
@jaalah-akamai jaalah-akamai requested review from jaalah-akamai and removed request for bnussman-akamai and harsh-akamai August 14, 2025 15:05
@jaalah-akamai jaalah-akamai self-assigned this Aug 14, 2025
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed rebuild and resize inputs disabled without respective permissions for IAM restricted user
✅ confirmed rebuild/resize inputs disabled according to grants model when IAM feature flag is off
✅ confirmed IAM / non restricted user can rebuild/resize (inputs not disabled)

thanks @aaleksee-akamai!

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 14, 2025
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified changes
✅ Code changes have equivalent permissions/grant
✅ Verified when IAM flag is disabled

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 14, 2025
@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 14, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 719 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing719 Passing4 Skipped123m 52s

@jaalah-akamai jaalah-akamai merged commit 9e46eb4 into linode:develop Aug 15, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! IAM (Identity & Access Management) Linodes Dealing with the Linodes section of the app

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants