fix: [UIE-9062] - IAM RBAC: IP Addresses permission fix#12689
fix: [UIE-9062] - IAM RBAC: IP Addresses permission fix#12689jaalah-akamai merged 3 commits intolinode:developfrom
Conversation
…linode_admin role
|
✅ The elements is the IP Addresses section are correctly enabled/disabled based on the grants/permissions for both the IAM and non-IAM users. |
|
merging develop into this branch to gauge e2e test failures, will be reviewing shortly! |
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts" |
|||||||||||||||||
jaalah-akamai
left a comment
There was a problem hiding this comment.
✅ Confirmed changed
✅ Code changes look good
✅ Thanks for TODOs - only comment would maybe to put the ticket number that should address it, i.e.: TODO: [UIE-1000] - Description
There was a problem hiding this comment.
✅ confirmed changes
✅ reviewed code
thanks @mpolotsk-akamai!
note: right now for a linode_viewer IAM account, seeing that Linode Interface stuff isn't disabled (but I do get an unauthorized error when trying to update stuff)
I can look into getting a PR up to try and integrate this with IAM/grants!
update: see #12708 - lmk if this makes sense, otherwise I can close it
Description 📝
IAM RBAC: IP Addresses permission fix.
The old logic used the Grants API’s
read_writegrant, which doesn’t work for theaccount_linode_adminrole. For now, we’re using theupdate_linodepermission to control IP Addresses actions until the new detailed permissions are ready.Changes 🔄
List any change(s) relevant to the reviewer.
update_linodepermission to enable/disable IP Addresses actionsScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
August 26th
How to test 🧪
Prerequisites
(How to setup test environment)
To test permissions using presets:
Enable MSW and use Legacy MSW Handlers.
Verification steps
(How to verify changes)
account_linode_adminandaccount_viewerroleslinode_viewerrole only, confirm the same controls are disabledAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅