Skip to content

fix: [M3-10473] - smoke-linode-landing-table.spec.ts test failure and correct Linodes Landing ordering bug #12690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnussman-akamai merged 3 commits into from
Aug 13, 2025
Merged

fix: [M3-10473] - smoke-linode-landing-table.spec.ts test failure and correct Linodes Landing ordering bug #12690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c6f22e
update test and fix preference key
bnussman Aug 13, 2025
743b163
Added changeset: Use older linodes landing page order preference key
bnussman Aug 13, 2025
c150b0c
Added changeset: Update `smoke-linode-landing-table.spec.ts` to accou…
bnussman Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12690-tech-stories-1755094972481.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Use older linodes landing page order preference key ([#12690](https://github.com/linode/manager/pull/12690))
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12690-tests-1755095013460.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tests
---

Update `smoke-linode-landing-table.spec.ts` to account for removal of `/dashboard` ([#12690](https://github.com/linode/manager/pull/12690))
2 changes: 1 addition & 1 deletion packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ describe('linode landing checks', () => {
});

it('checks the landing page side menu items', () => {
cy.findByTitle('Akamai - Dashboard').should('be.visible');
cy.findByTitle('Akamai - Cloud Manager').should('be.visible');
cy.findByTestId('menu-item-Linodes').should('be.visible');
cy.findByTestId('menu-item-Volumes').should('be.visible');
cy.findByTestId('menu-item-NodeBalancers').should('be.visible');
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/Linodes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export const LinodesLandingWrapper = React.memo(() => {
},
from: '/linodes',
},
preferenceKey: 'linodes_view_style',
preferenceKey: 'linodes-landing',
Copy link
Copy Markdown
Member Author

@bnussman-akamai bnussman-akamai Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preference key should be linodes-landing based on what I see here:

manager/packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts

Line 63 in 9849406

'linodes-landing': { order: 'asc', orderBy: 'label' },

});

const handleRegionFilter = (regionFilter: RegionFilter) => {
Expand Down