Skip to content

upcoming: [M3-10415] - Restrict access to the Identity & Access link from the Primary Nav for non-beta users.#12692

Closed
cpathipa wants to merge 50 commits intolinode:developfrom
cpathipa:M3-10415
Closed

upcoming: [M3-10415] - Restrict access to the Identity & Access link from the Primary Nav for non-beta users.#12692
cpathipa wants to merge 50 commits intolinode:developfrom
cpathipa:M3-10415

Conversation

@cpathipa
Copy link
Copy Markdown
Contributor

@cpathipa cpathipa commented Aug 13, 2025

Description 📝

The scope of the ticket is to ensure Identity & Access link is restricted for non beta users instead it renders the existing Users & Grants link.

Note: This is a following PR of #12670

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add Users & Grants link to conditionally render in PrimaryNav

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

8/26

Preview 📷

All users (Non beta) Beta users
image image

How to test 🧪

  • Checkout the branch and run the app in local.
  • Enable the iamRbacPrimaryNavChanges flag
  • Verify Users & Grants link under Administration section for non beta users
  • Verify Identity & Access link under Administration section for beta users
  • Verify no regression in existing functionality
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

cpathipa and others added 30 commits August 4, 2025 16:19
…094060.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…037270.md

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
@cpathipa cpathipa requested review from a team as code owners August 13, 2025 19:02
@cpathipa cpathipa requested review from cliu-akamai and removed request for a team August 13, 2025 19:02
@cpathipa cpathipa requested review from harsh-akamai and mjac0bs and removed request for a team August 13, 2025 19:02
@cpathipa cpathipa self-assigned this Aug 13, 2025
@linode-gh-bot
Copy link
Copy Markdown
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing714 Passing4 Skipped150m 9s

Details

Failing Tests
SpecTest
alerts-listing-page.spec.tsCloud Manager Cypress Tests→Integration Tests for CloudPulse Alerts Listing Page » should disable Create Alert button when user alert count reaches threshold
alerts-listing-page.spec.tsCloud Manager Cypress Tests→Integration Tests for CloudPulse Alerts Listing Page » should disable Create Alert button when metrics exceed threshold even if alerts are below limit
alerts-listing-page.spec.tsCloud Manager Cypress Tests→Integration Tests for CloudPulse Alerts Listing Page » should disable Create Alert when two alerts together use all 10 available metrics, and re-enable it after one is deleted
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/cloudpulse/alerts-listing-page.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

@cpathipa
Copy link
Copy Markdown
Contributor Author

Closing this PR since this PR #12693 includes this changes.

@mjac0bs
Copy link
Copy Markdown
Contributor

mjac0bs commented Aug 14, 2025

@cpathipa and I synced offline about this one and I confirmed the changes that unintentionally merged in, intended for this PR, looked good in develop. 👍🏼

Screenshot 2025-08-14 at 1 43 15 PM
Screenshot 2025-08-14 at 1 43 34 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants