upcoming:[DI-26661]: Add new filter - 'linode region' for firewalls#12704
Merged
venkymano-akamai merged 17 commits intolinode:developfrom Aug 19, 2025
Merged
Conversation
ankita-akamai
requested review from
dmcintyr-akamai,
dwiley-akamai and
hana-akamai
and removed request for
a team
Contributor
|
i took the liberty of updating your branch bc i fixed the broken test in linode-storage.spec.ts, and it passes now. other is still failing for some reason. |
dmcintyr-akamai
approved these changes
Aug 15, 2025
…e/linode_region_filter
…i/manager into feature/linode_region_filter
| dashboard, | ||
| isServiceAnalyticsIntegration, | ||
| preferences, | ||
| dependentFilters: resource_ids?.length |
Contributor
There was a problem hiding this comment.
will just the dependentFilterReference.current, won't work
Contributor
Author
There was a problem hiding this comment.
we need this for contextual view
.../src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilterValue/useFetchOptions.ts
Outdated
Show resolved
Hide resolved
.../src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilterValue/useFetchOptions.ts
Outdated
Show resolved
Hide resolved
venkymano-akamai
approved these changes
Aug 18, 2025
Contributor
There was a problem hiding this comment.
Approving pending comments, @ankita-akamai lets try to see if these works and fix
Contributor
Author
|
Thanks, I resolved above comments @venkymano-akamai ! |
Contributor
Author
|
Enhancement: Covered one more use case by updating xfilter for /instances call. @nikhagra-akamai Please verify once. |
…e/linode_region_filter
Collaborator
Cloud Manager UI test results🎉 730 passing tests on test run #8 ↗︎
|
Contributor
|
All checks are passing, enough approvals and code looks good |
This was referenced Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add new filter - 'linode region' for firewalls
Changes 🔄
filterconfig.ts.CloudPulseRegionSelect.tsxto make it flexible for different filterKeysuseFetchOptions.tshook for computation of linode regions based on dimension label.Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
26 aug 2025
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
(In devCloud)
/metricscall gets fired with the payload of following type -Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅