test: [M3-10450] - Fix failing test in linode-storage.spec.ts#12705
Merged
dmcintyr-akamai merged 5 commits intolinode:developfrom Aug 15, 2025
Merged
test: [M3-10450] - Fix failing test in linode-storage.spec.ts#12705dmcintyr-akamai merged 5 commits intolinode:developfrom
dmcintyr-akamai merged 5 commits intolinode:developfrom
Conversation
dmcintyr-akamai
requested review from
bnussman-akamai,
cliu-akamai and
mjac0bs
and removed request for
a team
Collaborator
Cloud Manager UI test results🎉 719 passing tests on test run #3 ↗︎
|
bnussman-akamai
approved these changes
Aug 14, 2025
Member
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Thanks for fixing this on! And for the detailed description and code comments!
mjac0bs
added
Approved
This was referenced Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Fix failing test in linode-storage.spec.ts. Purpose of test is to verify that linode can be deleted successfully.
Changes 🔄
Test always fails in linode-storage.spec.ts, in every branch. Change in backend broke unchanged code in test that was previously working. Failure started @ July 28 2025.
Test fails bc a linode disk w/ config of disk_encryption: 'enabled' fails to actually be deleted. So i modified the test to expect the disk to NOT be deleted. The UI seems to indicate that the disk is being deleted but then the disk remains in the list of disks. If the backend is ever updated to "fix" this apparent bug, then this test will break, so this test serves as a early warning indicator of the change in the backend.
I also added another test to test the deletion of a linode disk w/ disk_encryption: 'disabled', and this disk can be deleted as expected. Once deletion is confirmed, the disk is no longer visible in the list.
How to test 🧪
pnpm run cy:run -s cypress/e2e/core/linodes/linode-storage.spec.ts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅