Skip to content

upcoming: [DI-26793] - CloudPulse metric label support for Linode Interface firewall entities#12716

Merged
nikhagra-akamai merged 10 commits intolinode:developfrom
nikhagra-akamai:legend-label
Aug 19, 2025
Merged

upcoming: [DI-26793] - CloudPulse metric label support for Linode Interface firewall entities#12716
nikhagra-akamai merged 10 commits intolinode:developfrom
nikhagra-akamai:legend-label

Conversation

@nikhagra-akamai
Copy link
Copy Markdown
Contributor

Description 📝

Updated logic to map linode ids under linode interface type for firewall

Changes 🔄

List any change(s) relevant to the reviewer.

  1. Updated logic to add linode_interface parent entity for id to label mapping

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

26th August

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
Screenshot 2025-08-18 at 4 10 33 PM Screenshot 2025-08-18 at 12 47 42 PM

How to test 🧪

  1. Switch to mock user and go to metrics tab
  2. Select firewall dashboard and filters
  3. From firewalls mock response you'll see my-linode label has type linode and linode-123 is the parent entity of linode_interface entity
  4. That same will be reflected in the legend rows. Without this change you'll see linode id but with this change you'll see linode label
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@nikhagra-akamai nikhagra-akamai requested a review from a team as a code owner August 18, 2025 14:51
@nikhagra-akamai nikhagra-akamai requested review from mjac0bs and removed request for a team August 18, 2025 14:51
Copy link
Copy Markdown
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed that the linode label has replaced the linode id in the legend

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 18, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 18, 2025
@mjac0bs mjac0bs changed the title upcoming: [DI-26793] - Updated logic for linode id to label mappings upcoming: [DI-26793] - CloudPulse metric label support for Linode Interface firewall entities Aug 18, 2025
Copy link
Copy Markdown
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending Cypress tests finish in CI and look good.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 18, 2025
@linode-gh-bot
Copy link
Copy Markdown
Collaborator

Cloud Manager UI test results

🎉 730 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing730 Passing4 Skipped125m 56s

@nikhagra-akamai nikhagra-akamai merged commit 7787a19 into linode:develop Aug 19, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants