-
Notifications
You must be signed in to change notification settings - Fork 391
tech-story: [M3-10569] - Upgrade Cypress from v14.3.0 to v15.4.0 #12824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tech-story: [M3-10569] - Upgrade Cypress from v14.3.0 to v15.4.0 #12824
Conversation
|
Little issue with the video uploads on Cypress v15: it used to be that specs that passed didn't get a recording, now we're uploading a 0-byte mp4 for passing specs. Must be some issue with discardPassedTestRecordings, I'll take a look soon |
Updates inquirer package to 12.9.4 to help in resolving tmp allows arbitrary temporary file / directory write via symbolic link `dir` parameter This PR alone does not resolve tmp allows arbitrary temporary file / directory write via symbolic link `dir` parameter but this PR along with tech-story: [M3-10569] - Upgrade Cypress from v14.3.0 to v15.1.0 #12824 will resolve it.
|
This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days |
|
I'm going to cut our losses with the recording issue and just accept the annoyance for now in the interest of unblocking the Vite upgrade as well as M3-10596. Next week I'll take a look to see if it's worth trying to mitigate this from the pipeline, but not sure it'll be worth the effort (cc @bnussman-akamai) |
dwiley-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran clone-linode.spec.ts and create-firewall.spec.ts locally and they passed. Didn't observe any other issues and CI looks good otherwise ✅
Cloud Manager UI test results🔺 5 failing tests on test run #9 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/general/smoke-deep-link.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts" |
|||||||||||||||||||||||||||||
…ode#12824) * Upgrade Cypress from v14.3.0 to v15.4.0 * Add changeset
Description 📝
Upgrades Cypress and related dependencies to their latest versions. Refer to the Cypress changelog to see what's new in v15:
https://docs.cypress.io/app/references/changelog
I'm going to keep this in draft and see how it works in CI, and may push some additional updates to our Dockerfile.
Changes 🔄
Scope 🚢
Target release date 🗓️
N/A. Not urgent, but is blocking our upgrade to Vite v7. (See also #12792)
How to test 🧪
We can rely on CI for this.
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅