test: [M3-10365] - LKE-E "postLa" feature flag smoke tests #12886
Conversation
jdamore-linode
requested review from
cliu-akamai
and removed request for
a team
jdamore-linode
requested review from
bnussman-akamai and
coliu-akamai
and removed request for
a team
|
Just noticed the merge conflict! I'll tackle that tomorrow, but removed the "Ready for Review" label in the meantime |
packages/manager/cypress/e2e/core/kubernetes/smoke-lke-enterprise.spec.ts
Outdated
Show resolved
Hide resolved
| * - Confirms the state of the LKE create page when the LKE-E "postLa" flag is disabled. | ||
| * - Confirms that node pools are added directly via the plan table. | ||
| */ | ||
| it('Simple Page Check - Post LA Flag OFF', () => { |
There was a problem hiding this comment.
@jdamore-linode We could leave the "OFF" state test coverage for completeness, but since the postLa flag is enabled in prod now, and we haven't seen any need to retract that, it can be expected to remain on, and I'm not sure that the test is too useful. Do you think this test/any "Post LA OFF" is worth keeping?
There was a problem hiding this comment.
@mjac0bs I'd prefer to have the off state coverage if it's not too much of a maintenance burden! I think you're right and can't really imagine any scenarios where we'd have to turn the flag off that aren't farfetched, but on the other hand if we could anticipate every edge case scenario we wouldn't really need tests in the first place 😅 I'd really hate to be in a situation where we need to disable a flag on short notice only to find out that the off state is broken
There was a problem hiding this comment.
I think all these random CloudPulse changes are a result of Prettier running automatically when committing the merge from develop into this branch; I don't think the CloudPulse team runs Prettier when they commit, so these all got modified to apply our Prettier rules when I made my commit
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Thank you for this and handling the combinatorial explosion of feature flag cases in this file. 😅
I think your merge preserved the existing test cases from my previous PR, and thank you for the additions.
| * - Confirms VPC and IP Stack selections are shown with `phase2Mtc` feature flag is enabled. | ||
| * - Confirms VPC and IP Stack selections are not shown in create flow with `phase2Mtc` feature flag is disabled. |
There was a problem hiding this comment.
Minor regression from the merge. The deleted text alludes to multiple (nested) phase2 feature flags, rather than just a bool.
Though I think we should move this comment to the section that tests the phase 2 flows.
There was a problem hiding this comment.
Nice catch, thanks @mjac0bs! Just improved that wording and moved it to be above the "Phase 2 MTC feature flag" describe block
…unt for new LKE-E `phase2Mtc` feature flag properties
Cloud Manager UI test results🎉 819 passing tests on test run #5 ↗︎
|
bnussman-akamai
added
Approved
4 participants
Description 📝
This adds a handful of smoke tests that to confirm the state of the LKE cluster create and details pages when the LKE-E "postLa" feature flag is and is not enabled. It additionally adds some tests to confirm the pages work as expected when both "postLa" and "phase2Mtc" are enabled.
The diff is pretty big because I wrapped the existing tests in new
describeblocks, but these are the new tests:Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
N/A
How to test 🧪
We can rely on CI to confirm that the tests pass as expected. However, you can run the tests locally with this command:
pnpm cy:run -s "cypress/e2e/core/kubernetes/smoke-lke-enterprise.spec.ts"Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅