Skip to content

Conversation

@kagora-akamai
Copy link
Contributor

@kagora-akamai kagora-akamai commented Sep 22, 2025

Description 📝

Delivery bugfixes after devcloud release

Changes 🔄

  1. Audit logs details null handling (send stream details as null and handle response with null value)
  2. X-Filter header to not use contains for stream status
  3. Fixed Stream Disable action
  4. Missing Destination Type value in select in stream edit form
  5. Reset destination form when switching from existing destination to pristine state
  6. Left navbar, Delivery tab name changed to Logs

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • No customers / Not applicable

Target release date 🗓️

September 2025

Preview 📷

Before After
Screenshot 2025-09-22 at 17 08 34 Screenshot 2025-09-22 at 16 59 19
Screenshot 2025-09-22 at 17 04 07 Screenshot 2025-09-22 at 17 01 19
Screenshot 2025-09-22 at 17 05 42 Screenshot 2025-09-22 at 17 02 07
Screenshot 2025-09-22 at 13 12 09 Screenshot 2025-09-22 at 16 58 05

How to test 🧪

Prerequisites

  • Start manager with devcloud credentials

Verification steps

  • Navigate to logs/delivery/streams
  • Click on any existing stream with type Audit Logs -> redirect to edit stream page -> page should load without any errors
  • Navigate to logs/delivery/streams
  • Above table, choose Status select filter. -> Table should sort and not throw error.
  • Toggle action manu next to any stream and click Disable/Enable - request should succeed (not throw details filed error)
  • Click on any existing stream -> redirect to edit stream page
  • See if Delivery Type has value (should not display select an option)
  • Navigate to logs/delivery/streams
  • Create new stream
  • Choose existing delivery name
  • Type new name in Delivery Name field and choose option Create "new name" -> see the destination form is clean
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@kagora-akamai kagora-akamai self-assigned this Sep 22, 2025
@kagora-akamai kagora-akamai force-pushed the feature/DPS-34879-API-compatibility-fixes branch 2 times, most recently from b0a27a7 to 1ebe526 Compare September 22, 2025 16:25
@kagora-akamai kagora-akamai marked this pull request as ready for review September 22, 2025 16:28
@kagora-akamai kagora-akamai requested a review from a team as a code owner September 22, 2025 16:28
@kagora-akamai kagora-akamai requested review from coliu-akamai, dwiley-akamai and hasyed-akamai and removed request for a team and hasyed-akamai September 22, 2025 16:28
@kagora-akamai kagora-akamai force-pushed the feature/DPS-34879-API-compatibility-fixes branch from 1ebe526 to 108a40a Compare September 23, 2025 13:05
@kagora-akamai kagora-akamai added the Add'tl Approval Needed Waiting on another approval! label Sep 24, 2025
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing at the DevCloud environment locally and seeing this -- what am I missing? Is there a customer tag that's needed?

Screenshot 2025-09-25 at 2 06 10 PM

@kagora-akamai
Copy link
Contributor Author

kagora-akamai commented Sep 26, 2025

Pointing at the DevCloud environment locally and seeing this -- what am I missing? Is there a customer tag that's needed?

Screenshot 2025-09-25 at 2 06 10 PM

Hi @dwiley-akamai, could you attach screenshot of the error from browser's devtools Network tab for GET streams request?

@dwiley-akamai
Copy link
Contributor

Hi @dwiley-akamai, could you attach screenshot of the error from browser's devtools Network tab for GET streams request?

image

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 828 passing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing828 Passing11 Skipped38m 31s

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added customer tag and verified steps ✅

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Sep 30, 2025
@mikeZuber-akamai mikeZuber-akamai merged commit c63d15b into linode:develop Sep 30, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Sep 30, 2025
@kagora-akamai kagora-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 30, 2025
ryantqiu pushed a commit to snorkel-marlin-repos/manager_0f8f5cef that referenced this pull request Oct 1, 2025
ryantqiu added a commit to snorkel-marlin-repos/manager_0f8f5cef that referenced this pull request Oct 1, 2025
…r devcloud release

Merged from original PR #12898
Original: linode/manager#12898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Logs 🚨 Urgent

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants