Skip to content

feat: [STORIF-102] - Volume "AttachedTo" column updated#12903

Merged
bnussman-akamai merged 3 commits intolinode:developfrom
dchyrva-akamai:feature/STORIF-102
Oct 6, 2025
Merged

feat: [STORIF-102] - Volume "AttachedTo" column updated#12903
bnussman-akamai merged 3 commits intolinode:developfrom
dchyrva-akamai:feature/STORIF-102

Conversation

@dchyrva-akamai
Copy link
Contributor

@dchyrva-akamai dchyrva-akamai commented Sep 23, 2025

Description 📝

Volume "AttachedTo" column updated.

Changes 🔄

  • Created new "AttachedToValue" component.
  • Functionality responsible for displaying AttachedTo column value moved into the new component.
  • Added the third "Linode (restricted)" case to the functionality.
  • Tests added to secure the component.

Preview 📷

image image

How to test 🧪

  • Run pnpm dev command to start local environment.
  • Go to the "src -> features -> Volumes -> Partials -> AttachedToValue.tsx" file.
  • Add the following line inside the component function volume.io_ready = true;
  • Open browser and navigate to the Volumes page.
  • Observe the "AttachedTo" column.
  • Go to the Volume Details page.
  • Observe the "AttachedTo" column.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dchyrva-akamai dchyrva-akamai requested a review from a team as a code owner September 23, 2025 09:54
@dchyrva-akamai dchyrva-akamai requested review from bill-akamai and bnussman-akamai and removed request for a team September 23, 2025 09:54
@dchyrva-akamai dchyrva-akamai force-pushed the feature/STORIF-102 branch 3 times, most recently from 8e84c66 to 2d44a0f Compare September 23, 2025 10:01
@dchyrva-akamai dchyrva-akamai force-pushed the feature/STORIF-102 branch 2 times, most recently from 927d232 to 01a687c Compare September 23, 2025 13:08
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! I just have a few clean up items

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! Left two non-blocking suggestions

@dchyrva-akamai dchyrva-akamai force-pushed the feature/STORIF-102 branch 2 times, most recently from 6639ac6 to 5d7fa54 Compare October 1, 2025 08:33
@dchyrva-akamai dchyrva-akamai requested review from abailly-akamai and removed request for bill-akamai October 1, 2025 14:13
@dchyrva-akamai dchyrva-akamai force-pushed the feature/STORIF-102 branch 4 times, most recently from a04fa40 to 4740b66 Compare October 2, 2025 14:39
@bnussman-akamai bnussman-akamai changed the title feat: [STORIF-102] Volume "AttachedTo" column updated. feat: [STORIF-102] - Volume "AttachedTo" column updated Oct 2, 2025
@bnussman-akamai bnussman-akamai added the Volumes Relating to Volumes (aka Block Storage) label Oct 2, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Oct 6, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #23 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing834 Passing13 Skipped39m 57s

Details

Failing Tests
SpecTest
create-firewall.spec.tsCloud Manager Cypress Tests→create firewall » "before all" hook for "creates a firewall without a linode"
create-firewall.spec.tsCloud Manager Cypress Tests→restricted user cannot create firewall » "before each" hook for "confirms the create button is disabled on the Firewall Landing page"

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts"

*
* @TODO BSE: Remove optionality once BSE is fully rolled out
*/
encryption?: VolumeEncryption; //
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
encryption?: VolumeEncryption; //
encryption?: VolumeEncryption;

@bnussman-akamai bnussman-akamai merged commit c7b7d76 into linode:develop Oct 6, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Oct 6, 2025
@dchyrva-akamai dchyrva-akamai deleted the feature/STORIF-102 branch October 6, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Volumes Relating to Volumes (aka Block Storage)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants