feat: [STORIF-102] - Volume "AttachedTo" column updated#12903
Merged
bnussman-akamai merged 3 commits intolinode:developfrom Oct 6, 2025
Merged
feat: [STORIF-102] - Volume "AttachedTo" column updated#12903bnussman-akamai merged 3 commits intolinode:developfrom
bnussman-akamai merged 3 commits intolinode:developfrom
Conversation
8e84c66 to
2d44a0f
Compare
2d44a0f to
08dcbb2
Compare
packages/manager/src/features/Volumes/Partials/AttachedToValue.tsx
Outdated
Show resolved
Hide resolved
927d232 to
01a687c
Compare
skulpok-akamai
approved these changes
Sep 23, 2025
Member
bnussman-akamai
left a comment
There was a problem hiding this comment.
Code looks great! I just have a few clean up items
packages/manager/src/features/Volumes/Partials/AttachedToValue.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Volumes/Partials/AttachedToValue.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Volumes/Partials/AttachedToValue.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Volumes/Partials/AttachedToValue.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Volumes/Partials/AttachedToValue.test.tsx
Outdated
Show resolved
Hide resolved
8fb3c11 to
528d719
Compare
528d719 to
60018f6
Compare
skulpok-akamai
approved these changes
Sep 26, 2025
60018f6 to
c1b0ca5
Compare
bnussman-akamai
approved these changes
Sep 26, 2025
Member
bnussman-akamai
left a comment
There was a problem hiding this comment.
Code looks great! Left two non-blocking suggestions
c1b0ca5 to
6b42168
Compare
6b42168 to
9df14da
Compare
6639ac6 to
5d7fa54
Compare
a04fa40 to
4740b66
Compare
4740b66 to
485c8ad
Compare
abailly-akamai
approved these changes
Oct 6, 2025
485c8ad to
0e526ff
Compare
0e526ff to
64f8274
Compare
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #23 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts" |
||||||||||||||||||||
| * | ||
| * @TODO BSE: Remove optionality once BSE is fully rolled out | ||
| */ | ||
| encryption?: VolumeEncryption; // |
Member
There was a problem hiding this comment.
Suggested change
| encryption?: VolumeEncryption; // | |
| encryption?: VolumeEncryption; |
This was referenced Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Volume "AttachedTo" column updated.
Changes 🔄
Preview 📷
How to test 🧪
pnpm devcommand to start local environment.volume.io_ready = true;Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅