feat: [UIE-9251] - IAM Delegation: Add Account Delegations Tab#12927
Merged
mpolotsk-akamai merged 7 commits intolinode:developfrom Oct 10, 2025
Merged
Conversation
packages/manager/src/features/IAM/Delegations/AccountDelegations.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Delegations/AccountDelegations.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Delegations/AccountDelegationsTable.tsx
Show resolved
Hide resolved
mpolotsk-akamai
added
the
IAM Delegation
mpolotsk-akamai
force-pushed
the
UIE-9251-account-delegation-tab
branch
from
0da7b9f to
e505be9
Compare
abailly-akamai
approved these changes
Oct 7, 2025
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Looks great! left a few non-blocking comments but this looks good to go from my end 👍
packages/manager/src/features/IAM/Delegations/AccountDelegations.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Delegations/AccountDelegations.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Delegations/AccountDelegationsTable.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/IAM/Delegations/AccountDelegationsTableRow.tsx
Show resolved
Hide resolved
… functionality for users
mpolotsk-akamai
force-pushed
the
UIE-9251-account-delegation-tab
branch
from
e505be9 to
9b10d50
Compare
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/firewalls/create-firewall.spec.ts" |
||||||||||||||||||||
| <TruncatedList | ||
| addEllipsis | ||
| customOverflowButton={(numHiddenItems) => ( | ||
| // TODO: move to the separate component |
Contributor
There was a problem hiding this comment.
is there a ticket for that or you'll do that in this PR?
Contributor
There was a problem hiding this comment.
This component is pretty small (~100 lines) so unless we need to reuse it i think it could stay like this
| if (isLoading) { | ||
| return <CircleProgress />; | ||
| } | ||
| if (!flags.iamDelegation?.enabled) { |
Contributor
There was a problem hiding this comment.
remember to use the new useIsIAMDelegationEnabled to be consistent 👍
abailly-akamai
approved these changes
Oct 10, 2025
|
|
||
| return order === 'asc' ? comparison : -comparison; | ||
| }); | ||
| }, [filteredDelegations, order]); |
Contributor
There was a problem hiding this comment.
We can prob change this when we get API support for filtering, but useOrderV2 will help you there because it also handles query params
see #12974
aaleksee-akamai
approved these changes
Oct 10, 2025
This was referenced Oct 16, 2025
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Dec 8, 2025
…e#12927) * feat: [UIE-9251] - IAM Delegation: Add Account Delegation Tab * feat: [UIE-9251] - Add client side sorting, filtering and expand/hide functionality for users * feat: [UIE-9251] - review updates, refactoring * feat: [UIE-9251] - style fix * feat: [UIE-9251] - unit test * Added changeset: IAM: Account Delegations Tab * feat: [UIE-9251] - review fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR implements a new "Account Delegations" tab under Identity and Access.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
October 21st
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
IAM Delegation (Parent/Child)flag should be enabled)Verification steps
(How to verify changes)
Child Accounts & Delegationsin DevTools (e.g., 100).Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅