refactor: [M3-10638] - VPC IPv4 and IPv6 address code clean up#12940
Merged
hana-akamai merged 8 commits intolinode:developfrom Oct 6, 2025
Merged
refactor: [M3-10638] - VPC IPv4 and IPv6 address code clean up#12940hana-akamai merged 8 commits intolinode:developfrom
hana-akamai merged 8 commits intolinode:developfrom
Conversation
Contributor
|
Planning to review first thing on Monday 👍🏾 |
bnussman-akamai
approved these changes
Oct 6, 2025
dwiley-akamai
approved these changes
Oct 6, 2025
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Code review ✅
Checks pass ✅
No regressions observed in Linode Create, Config dialog, Add/Edit Interface flows ✅
One small comment re: VPC IPv4 placeholder text
...ager/src/features/Linodes/LinodesDetail/LinodeNetworking/LinodeInterfaces/VPCIPv4Address.tsx
Outdated
Show resolved
Hide resolved
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
This was referenced Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Clean up duplicate VPC IPv4 and IPv6 address / public access code across the various VPC flows
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
There should be no visual changes
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅