-
Notifications
You must be signed in to change notification settings - Fork 391
fix: [UIE-9300] - isIAMEnabled LA access check
#12946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
bnussman-akamai
approved these changes
Oct 2, 2025
Member
bnussman-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alban!
kwojtowiakamai
approved these changes
Oct 3, 2025
kwojtowiakamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works correctly for non-Beta/Beta/LA users. Thanks @abailly-akamai
aaleksee-akamai
approved these changes
Oct 3, 2025
Collaborator
Cloud Manager UI test results🎉 836 passing tests on test run #4 ↗︎
|
abailly-akamai
added a commit
to abailly-akamai/manager
that referenced
this pull request
Oct 4, 2025
* fix + loading state * Added changeset: IAM - isIAMEnabled LA access check
7 tasks
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Issue: When the LA feature flag is enabled in CM, users without account roles do not see IAM, even if they have entity roles assigned.
Fix: now we only really need to check if the IAM account/permissions query returns successfully, even if empty
Additionally, when loading the IAM landing page we were showing a NotFound state till isIAMEnabled had finished running, which was an odd experience. This PR implements a loading state for a better user experience.
Changes 🔄
iam/users(and children) initial loading experienceScope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Reproduction steps
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅