Skip to content

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Oct 2, 2025

Description 📝

Issue: When the LA feature flag is enabled in CM, users without account roles do not see IAM, even if they have entity roles assigned.

Fix: now we only really need to check if the IAM account/permissions query returns successfully, even if empty

Additionally, when loading the IAM landing page we were showing a NotFound state till isIAMEnabled had finished running, which was an odd experience. This PR implements a loading state for a better user experience.

Changes 🔄

  • Only serve legacy experience if the account/permissions query fails (user does not have the IAM tag)
  • Improve iam/users (and children) initial loading experience

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

How to test 🧪

Reproduction steps

  • Login to CM with LA enabled as user without any account roles assigned
  • 🚫 IAM section is not visible, CM do not use the new permissions system

Verification steps

  • Login to CM with LA enabled as user without any account roles assigned
  • ✅ IAM section is visible, CM uses the new permissions system
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai requested a review from a team as a code owner October 2, 2025 14:29
@abailly-akamai
Copy link
Contributor Author

CC @kwojtowiakamai

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alban!

Copy link

@kwojtowiakamai kwojtowiakamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly for non-Beta/Beta/LA users. Thanks @abailly-akamai

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Oct 3, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 836 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing836 Passing11 Skipped38m 44s

@abailly-akamai abailly-akamai merged commit a2bd44d into linode:develop Oct 3, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Oct 3, 2025
abailly-akamai added a commit to abailly-akamai/manager that referenced this pull request Oct 4, 2025
* fix + loading state

* Added changeset: IAM - isIAMEnabled LA access check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants