test: [M3-10521] - Fix failing alerts-create.spec.ts test in DevCloud
#12952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
changed the title
alerts-create.spec.ts test in DevCloud
dmcintyr-akamai
requested review from
cliu-akamai
and removed request for
a team
Collaborator
Cloud Manager UI test results🎉 832 passing tests on test run #4 ↗︎
|
dwiley-akamai
approved these changes
Oct 2, 2025
| "@linode/manager": Tests | ||
| --- | ||
|
|
||
| Fix failing "alerts-create.spec.ts" ts in DevCloud ([#12952](https://github.com/linode/manager/pull/12952)) |
Contributor
There was a problem hiding this comment.
Suggested change
| Fix failing "alerts-create.spec.ts" ts in DevCloud ([#12952](https://github.com/linode/manager/pull/12952)) | |
| Fix failing "alerts-create.spec.ts" in DevCloud ([#12952](https://github.com/linode/manager/pull/12952)) |
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
One of the tests in alerts-create.spec.ts was failing bc the relevant button was below the fold when the code snippet window opened.
Test now passes in devcloud, and it still passes in dev environment.
Changes 🔄
Fix is to append .scrollIntoView() to the button. I added it in another place where the same button is retrieved even tho that test is not failing (yet).
I am fairly confident that the fix will remove the flakiness, as i can get the test to pass in cypress by manually scrolling the window so that the button is above the fold.
Scope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
pnpm run cy:run -s cypress/e2e/core/linodes/alerts-create.spec.ts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅