Skip to content

upcoming: [DPS-34981] - Logs - Improve delete action#12956

Merged
mikeZuber-akamai merged 3 commits intolinode:developfrom
kagora-akamai:feature/DPS-34981-improve-delete-action
Oct 14, 2025
Merged

upcoming: [DPS-34981] - Logs - Improve delete action#12956
mikeZuber-akamai merged 3 commits intolinode:developfrom
kagora-akamai:feature/DPS-34981-improve-delete-action

Conversation

@kagora-akamai
Copy link
Contributor

@kagora-akamai kagora-akamai commented Oct 3, 2025

Description 📝

Logs Destination and Stream delete action improvement.

Changes 🔄

  • on Delete action for Stream open Dialog with confirmation.
  • on Delete action for Destination open Dialog with confirmation.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • No customers / Not applicable

Target release date 🗓️

October 2025

Preview 📷

Before After
Screenshot 2025-10-03 at 11 01 56 Screenshot 2025-10-03 at 11 03 02
Screenshot 2025-10-03 at 11 02 30 Screenshot 2025-10-03 at 11 02 54

How to test 🧪

Prerequisites

  • Start manager with either devcloud credentials or enable Mock CRUD in devtools

Verification steps

  • Navigate to /logs/delivery/streams/
  • Open action menu next to any stream
  • Click on Delete action -> Dialog modal should be visible with Cancel and Delete options
  • Navigate to /logs/delivery/destinations/
  • Open action menu next to any destination
  • Click on Delete action -> Dialog modal should be visible with Cancel and Delete options
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@kagora-akamai kagora-akamai force-pushed the feature/DPS-34981-improve-delete-action branch from 9198b31 to 40267cc Compare October 3, 2025 09:49
@kagora-akamai kagora-akamai marked this pull request as ready for review October 6, 2025 08:30
@kagora-akamai kagora-akamai requested a review from a team as a code owner October 6, 2025 08:30
@github-project-automation github-project-automation bot moved this from Review to Changes Requested in Cloud Manager Oct 6, 2025
@kagora-akamai kagora-akamai force-pushed the feature/DPS-34981-improve-delete-action branch from 8cd888d to 1daa534 Compare October 7, 2025 08:57
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 3 failing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing823 Passing13 Skipped39m 45s

Details

Failing Tests
SpecTest
create-firewall.spec.tsCloud Manager Cypress Tests→create firewall » "before all" hook for "creates a firewall without a linode"
create-firewall.spec.tsCloud Manager Cypress Tests→restricted user cannot create firewall » "before each" hook for "confirms the create button is disabled on the Firewall Landing page"
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts"

@kagora-akamai kagora-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 9, 2025
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ✅
Verification steps ✅

@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in Cloud Manager Oct 13, 2025
@mikeZuber-akamai mikeZuber-akamai merged commit 68080de into linode:develop Oct 14, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Oct 14, 2025
@kagora-akamai kagora-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 28, 2025
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Logs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants