feat: [UIE-9306] IAM / RBAC MSW CRUD Users, Delegation and Parent /Child Updates #12957
Conversation
abailly-akamai
force-pushed
the
UIE-9306
branch
from
0e6015f to
7fca15f
Compare
abailly-akamai
force-pushed
the
UIE-9306
branch
from
3e6d773 to
bc32597
Compare
abailly-akamai
changed the title
| | 'view_billing_invoice' | ||
| | 'view_billing_payment' | ||
| | 'view_invoice_item' | ||
| | 'view_payment_method'; |
There was a problem hiding this comment.
we were missing a lot of permissions - i added those based on the actual response from the API
| return [k, initialValue]; | ||
| } | ||
| }) | ||
| ), |
There was a problem hiding this comment.
no need for manually adding those anymore 😫 🎉
| }, | ||
| ], | ||
| }) as IamAccess, | ||
| }, |
There was a problem hiding this comment.
Update the factory to be much closer to the actual response
| default: | ||
| return entity; | ||
| } | ||
| }; |
There was a problem hiding this comment.
this is unfortunately necessary since we have divergent naming conventions between mocked entities and actual entity types. Refactoring mocks would bring in too much work..
| 'stackscript', | ||
| 'volume', | ||
| 'vpc', | ||
| ]; |
There was a problem hiding this comment.
only those get automatically added to entities when being created
abailly-akamai
changed the title
|
@aaleksee-akamai @mpolotsk-akamai I know this is a large PR - i don't expect everything to be quite perfect for mock data quite yet, but this should be a decent effort to match API behavior as far as we know it. Once merged, we will likely need to tweak some of the mocking so the goal is to merge and iterate where needed One thing to remember: the real CRUD mode (actually interacting with entities and feature) should be done with mock data we create in the store. SEED data always reset after a page reload so while it supports the same CRUD methods it will not persist. |
Cloud Manager UI test results🔺 3 failing tests on test run #11 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||||||||
abailly-akamai
added
IAM Delegation
4 participants
Description 📝
Pretty large refactor to leverage the whole user mocking + handles IAM & Parent / Child
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
How to test 🧪
Prerequisites
Verification steps
👉 Turn on MSW CRUD and:
indexedDBstore in dev inspectorindexedDB:Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅