upcoming: [DI-27110] - Added preference support to ACLP group by #12969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value selection as per configuration or preferences
…ial group by selection
bnussman-akamai
approved these changes
Oct 9, 2025
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
This was referenced Oct 16, 2025
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Dec 8, 2025
…ode#12969) * upcoming: [DI-27110] - Added preference support for group by * upcoming: [DI-27110] - Updated typecheck * upcoming: [DI-27110] - Renamed props * upcoming: [DI-27110] - Updated failing test cases * upcoming: [DI-27110] - Added test cases * upcoming: [DI-27110] - Updated logic to maintain the order of default value selection as per configuration or preferences * upcomign: [DI-27110] - Updated logic to avoid preference call on initial group by selection * upcoming: [DI-27110] - Updated save preferences logic * upcoming: [DI-27110] - Updated test cases * added changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Added preference support to ACLP group by
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
October, 21st
Preview 📷
Include a screenshot
<img src="" />or video<video src="" />of the change.🔒 Use the Mask Sensitive Data setting for security.
💡 For changes requiring multiple steps to validate, prefer a video for clarity.
Screen.Recording.2025-10-08.at.5.24.13.PM.mov
Screen.Recording.2025-10-08.at.5.25.35.PM.mov
How to test 🧪
Prerequisites
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅