-
Notifications
You must be signed in to change notification settings - Fork 391
feat: [UIE-9181] - DBaaS - Display read-only hostname in connection details tables based on VPC configuration #12976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UIE-9181] - DBaaS - Display read-only hostname in connection details tables based on VPC configuration #12976
Conversation
…etails tables based on VPC configuration
a6c1ab9 to
fd48bd5
Compare
| <ConnectionDetailsRow label="Public Read-only Host"> | ||
| {getReadOnlyHostContent('public')} | ||
| </ConnectionDetailsRow> | ||
| )} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main changes for this pull request are here. I made the same type of change that I made to the Host field in my previous PR so that it renders the different variations of the field based on the VPC configuration.
(ie. Read-only Host, Private Read-only Host, and Public Read-only Host)
|
|
||
| interface DatabaseHosts { | ||
| primary: string; | ||
| primary?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the documentation, the backend doesn't always provide these hostnames. There's existing logic in the UI to add a placeholder for these fields as well, so I've updated the interface here to reflect that.
For standby, it seems to be excluded from the hosts object for single node clusters. I'm not sure what scenario excludes primary but I assume that's handled the same way. Going to check with the backend to make sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with the backend and the Hosts object can be null. Changing this to update the hosts type in the DatabaseInstance interface instead
Cloud Manager UI test results🔺 3 failing tests on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/firewalls/create-firewall.spec.ts" |
|||||||||||||||||||||||
…etails tables based on VPC configuration (linode#12976) * feat: [UIE-9181] - DBaaS - Display read-only hostname in connection details tables based on VPC configuration * Updating database.hosts types and serverHandler database instance hosts behavior * Adding changesets * Updating Database instance host property type to include null and updating changeset
Description 📝
This pull request is display the
Read-only Hostfield in the connection details tables that appear in the Summary and Networking tabs based on VPC configuration for the database.Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
10/21/2025
Preview 📷
Note: The before and after screenshots in each scenario show the Connection details tables in the Database Details Summary and Networking tabs.
Scenario 1: Database Cluster with No VPC Configured displays
Read-only HostfieldSummary:
Networking:
Scenario 2. Database Cluster with VPC configured and Public Access set to
falsedisplaysPrivate Read-only HostfieldSummary:
Networking:
Scenario 3. Database Cluster with VPC configured and Public Access set to
truedisplays both thePrivate Read-only HostandPublic Read-only HostfieldsSummary:
Networking:
How to test 🧪
Prerequisites
(How to setup test environment)
Have the
databaseVpcfeature flag enabledHave access to the Databases tab with the ability to create a Database Cluster
Have VPC and subnets created for a region
Use mock data or follow the steps below create databases in staging to test each scenario:
Note 1: This can be tested using the staging environment or with mock data. I'll provide instructions for mock data in the verification steps.
Note 2: If creating databases, I suggest giving these databases names to indicate the state so they're easy to distinguish (ie. database-with-vpc-public)
Create a Database with no VPC configuration and, in the
Set Number of Nodessection, select 2 or 3 nodes.Create a Database assigning a VPC/Subnet with the
Enable public accessfield checkboxcheckedand, in theSet Number of Nodessection, select 2 or 3 nodes.Create a Database assigning a VPC/Subnet with the
Enable public accessfield checkboxuncheckedand, in theSet Number of Nodessection, select 2 or 3 nodes.Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Note: This change applied to the
Read-only Hostfield and it now mirrors the same behavior for theHostfield based on the scenarios below.Note: You can use mock data to test the scenarios below. For mock data, you'll need to modify the database instance response to response to reflect each Database VPC configuration scenario. If you created the database clusters in staging, you can skip the mock data configuration steps.
Scenario 1. Database Cluster with No VPC Configured displays
Read-only Hostfieldprivate_networkproperty returned from the database instances request isnullby default in the database.ts file on line 244 to:Summarytab.Connection Detailstable, theRead-only Hostfield is displayed below theHostfield (See Before/After screenshots above)Manage Networkingsection connection details table.Read-only Hostfield is displayed below theHostfield. This should still be the same as the previous display behavior.Scenario 2. Database Cluster with VPC configured and Public Access set to false displays
Private Read-only Hostfieldprivate_networkproperty in the database.ts file on line 244 to:Connection Detailstable, thePrivate Read-only Hostfield is displayed below thePrivate Hostfield (See Before/After screenshots above)Manage Networkingsection connection details table.Private Read-only Hostfield is displayed below thePrivate Hostfield.Scenario 3. Database Cluster with VPC configured and Public Access set to true displays both the
Private Read-only HostandPublic Read-only Hostfieldsprivate_networkproperty in the database.ts file on line 244 to:Connection Detailstable, both thePrivate Read-only HostandPublic Read-only Hostfields are displayed below thePublic Hostfield in that order (See Before/After screenshots above)Public Read-only Hostfield, the hostname value starts withpublic-instead ofprivate-which is shown in thePrivate Read-only Hostfield hostname value.Manage Networkingsection connection details table.Private Read-only HostandPublic Read-only Hostfields are displayed below thePublic Hostfield in that order.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅