Skip to content

fix: [M3-10430] - Focus Indicator on MUI Toggle#12988

Merged
shagufa-akamai merged 3 commits intolinode:developfrom
shagufa-akamai:feature/M3-10430
Oct 21, 2025
Merged

fix: [M3-10430] - Focus Indicator on MUI Toggle#12988
shagufa-akamai merged 3 commits intolinode:developfrom
shagufa-akamai:feature/M3-10430

Conversation

@shagufa-akamai
Copy link
Contributor

@shagufa-akamai shagufa-akamai commented Oct 14, 2025

Description 📝

Prevent focus indicator on MUI Toggle from being cut off and misaligned

Changes 🔄

List any change(s) relevant to the reviewer.

  • update css on toggle.tsx file

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Include a screenshot <img src="" /> or video <video src="" /> of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 For changes requiring multiple steps to validate, prefer a video for clarity.

Before After
Before After

How to test 🧪

Prerequisites

(How to setup test environment)

  • Not special setup needed. Just focus the toggle button with keyboard to replicate the issue.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@shagufa-akamai shagufa-akamai requested a review from a team as a code owner October 14, 2025 21:40
@shagufa-akamai shagufa-akamai requested review from mjac0bs and removed request for a team October 14, 2025 21:40
@shagufa-akamai shagufa-akamai marked this pull request as draft October 14, 2025 21:45
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shagufa-akamai Change set is missing, here is the documentation for changeset.

…ausing visual inconsistency when navigating via keyboard
@shagufa-akamai shagufa-akamai marked this pull request as ready for review October 15, 2025 15:08
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first Cloud Manager PR, @shagufa-akamai! 🎉

Thanks for the fix. The focus indicator is a complete circle now.

You can disregard the test failure in CI - looks like unrelated flake. Looks good to merge once CI passes again - rekicking off CI now.

Screen.Recording.2025-10-15.at.10.01.07.AM.mov

Image

Unrelated to this PR: while testing, I noticed that our focus color in light mode for a disabled toggle isn't ideal because it's not fully visible (blends into the white paper background). This isn't a problem in dark mode. Would you mind creating a follow-up M3 ticket to look into fixing this? (If you don't have proper access yet, just let me know, and I can.)

@shagufa-akamai
Copy link
Contributor Author

Congrats on your first Cloud Manager PR, @shagufa-akamai! 🎉

Thanks for the fix. The focus indicator is a complete circle now.

You can disregard the test failure in CI - looks like unrelated flake. Looks good to merge once CI passes again - rekicking off CI now.

Screen.Recording.2025-10-15.at.10.01.07.AM.mov
Image

Unrelated to this PR: while testing, I noticed that our focus color in light mode for a disabled toggle isn't ideal because it's not fully visible (blends into the white paper background). This isn't a problem in dark mode. Would you mind creating a follow-up M3 ticket to look into fixing this? (If you don't have proper access yet, just let me know, and I can.)

Thanks @mjac0bs.

I have created a ticket for the new issue.
https://jira.linode.com/browse/M3-10680

@mjac0bs mjac0bs added Add'tl Approval Needed Waiting on another approval! Bug Fixes for regressions or bugs labels Oct 15, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing840 Passing11 Skipped43m 52s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! 🎉

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Oct 20, 2025
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 20, 2025
@shagufa-akamai shagufa-akamai merged commit eebbd63 into linode:develop Oct 21, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants