upcoming: [DPS-35222] - Logs destination/stream delete modal error state does not reset#12996
Merged
mikeZuber-akamai merged 2 commits intolinode:developfrom Oct 27, 2025
Conversation
…ate does not reset
…n modal error state reset fix
Collaborator
Cloud Manager UI test results🔺 7 failing tests on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/linodes/vm-host-maintenance-linode.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||||||||||||||||||||
dwiley-akamai
approved these changes
Oct 21, 2025
Contributor
dwiley-akamai
left a comment
There was a problem hiding this comment.
Code review ✅
Verification steps ✅
jdamore-linode
approved these changes
Oct 27, 2025
This was referenced Oct 30, 2025
shagufa-akamai
pushed a commit
to shagufa-akamai/manager
that referenced
this pull request
Dec 11, 2025
…ate does not reset (linode#12996) * upcoming: [DPS-35222] - Logs destination/stream delete modal error state does not reset * Added changeset: Logs Delivery Destinations/Stream Delete confirmation modal error state reset fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Bug fix for confirmation dialog for Destination delete action. Error state did not reset when modal Canceled and reopened for different destination.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
November 2025
Preview 📷
How to test 🧪
Prerequisites
start manager with Mock CRUD enabled
navigate to
/logs/delivery/destinationscreate 2 Destinations
navigate to Streams tab and create a stream using one of the existing destinations
Reproduction steps
/logs/delivery/destinationsVerification steps
/logs/delivery/destinationsAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support
As an Author, before moving this PR from Draft to Open, I confirmed ✅