Skip to content

upcoming: [DPS-35271] clean up not needed fields from types#13038

Merged
mduda-akamai merged 3 commits intolinode:developfrom
kagora-akamai:feature/DPS-35271-clean-up-not-needed-fields-from-types
Nov 12, 2025
Merged

upcoming: [DPS-35271] clean up not needed fields from types#13038
mduda-akamai merged 3 commits intolinode:developfrom
kagora-akamai:feature/DPS-35271-clean-up-not-needed-fields-from-types

Conversation

@kagora-akamai
Copy link
Contributor

@kagora-akamai kagora-akamai commented Oct 30, 2025

Description 📝

Delivery interfaces cleanup unnecessary props

Changes 🔄

  • Remove not existing properties
  • Adjust Destination interface

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • Some customers (e.g. in Beta or Limited Availability)

Target release date 🗓️

November 2025

How to test 🧪

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@kagora-akamai kagora-akamai force-pushed the feature/DPS-35271-clean-up-not-needed-fields-from-types branch from 792c807 to ddc4209 Compare October 30, 2025 14:10
@kagora-akamai kagora-akamai self-assigned this Oct 30, 2025
@kagora-akamai kagora-akamai marked this pull request as ready for review October 30, 2025 14:32
@kagora-akamai kagora-akamai requested a review from a team as a code owner October 30, 2025 14:32
@kagora-akamai kagora-akamai added the Add'tl Approval Needed Waiting on another approval! label Nov 5, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Nov 10, 2025
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 10, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 5 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
5 Failing854 Passing13 Skipped44m 9s

Details

Failing Tests
SpecTest
create-firewall.spec.tsCloud Manager Cypress Tests→create firewall » "before all" hook for "creates a firewall without a linode"
create-firewall.spec.tsCloud Manager Cypress Tests→restricted user cannot create firewall » "before each" hook for "confirms the create button is disabled on the Firewall Landing page"
update-stackscripts.spec.tsCloud Manager Cypress Tests→Update stackscripts » updates a StackScript
create-stackscripts.spec.tsCloud Manager Cypress Tests→Create stackscripts » creates a StackScript and deploys a Linode with it
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts,cypress/e2e/core/stackscripts/update-stackscripts.spec.ts,cypress/e2e/core/stackscripts/create-stackscripts.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts"

@mduda-akamai mduda-akamai merged commit 31fc451 into linode:develop Nov 12, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Logs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants