Skip to content

fix: [UIE-9484] - Enhance enabled checks for queries ran within useQueryWithPermissions #13039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwiley-akamai merged 2 commits into from
Oct 30, 2025
Merged

fix: [UIE-9484] - Enhance enabled checks for queries ran within useQueryWithPermissions #13039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9263d6
conditional run large ALL useQueryWithPermissions queries
abailly-akamai Oct 30, 2025
709a089
Added changeset: Enhance `enabled` checks for queries ran within `use…
abailly-akamai Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13039-fixed-1761836949620.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

Enhance `enabled` checks for queries ran within `useQueryWithPermissions` ([#13039](https://github.com/linode/manager/pull/13039))
2 changes: 1 addition & 1 deletion packages/manager/src/features/Firewalls/FirewallDetail/Devices/AddLinodeDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const AddLinodeDrawer = (props: Props) => {

const { data: availableLinodes, isLoading: availableLinodesLoading } =
useQueryWithPermissions<Linode>(
useAllLinodesQuery({}, {}),
useAllLinodesQuery({}, {}, open),
'linode',
['update_linode'],
open
Copy link
Contributor Author

@abailly-akamai abailly-akamai Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we'd have a more sensible mechanism for doing this, but this is the quickest and most economical option for the fix to be released quickly

Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/Images/ImagesCreate/CreateImageTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export const CreateImageTab = () => {
);

const { data: linodes, isLoading } = useQueryWithPermissions<Linode>(
useAllLinodesQuery(),
useAllLinodesQuery({}, {}, Boolean(imagePermissions.create_image)),
'linode',
['view_linode', 'update_linode'],
Boolean(imagePermissions.create_image)
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/Images/ImagesLanding/RebuildImageDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const RebuildImageDrawer = (props: Props) => {

const navigate = useNavigate();
const { data: linodes, isLoading } = useQueryWithPermissions<Linode>(
useAllLinodesQuery(),
useAllLinodesQuery({}, {}, open),
'linode',
['rebuild_linode', 'view_linode'],
open
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/NodeBalancers/NodeBalancerSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export const NodeBalancerSelect = (
error: availableNodebalancersError,
isLoading: availableNodebalancersLoading,
} = useQueryWithPermissions<NodeBalancer>(
useAllNodeBalancersQuery(),
useAllNodeBalancersQuery(Boolean(optionsFilter)),
'nodebalancer',
['update_nodebalancer'],
Boolean(optionsFilter)
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/VPCs/VPCDetail/SubnetUnassignLinodesDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export const SubnetUnassignLinodesDrawer = React.memo(
// TODO: change to 'delete_linode_config_profile_interface' once it's available
const { data: filteredLinodes, isLoading: isLoadingFilteredLinodes } =
useQueryWithPermissions<Linode>(
useAllLinodesQuery(),
useAllLinodesQuery({}, {}, open),
'linode',
['delete_linode'],
open
Expand Down