Skip to content

Tech story: [UIE-8943] - Replace dropdowns in Database cluster settings page with CDS select web component#13057

Merged
grevanak-akamai merged 3 commits intolinode:developfrom
grevanak-akamai:feature/UIE-8943
Dec 4, 2025
Merged

Tech story: [UIE-8943] - Replace dropdowns in Database cluster settings page with CDS select web component#13057
grevanak-akamai merged 3 commits intolinode:developfrom
grevanak-akamai:feature/UIE-8943

Conversation

@grevanak-akamai
Copy link
Contributor

@grevanak-akamai grevanak-akamai commented Nov 5, 2025

Description 📝

This PR is to replace dropdowns in Database cluster settings page with CDS select web component.

Changes 🔄

  • Replaced day and time dropdowns under weekly maintenance section in database cluster settings page with CDS select Web Component.

Target release date 🗓️

N/A

Preview 📷

Before After
Screenshot 2025-07-24 at 2 10 02 PM Screenshot 2025-07-24 at 2 10 12 PM

How to test 🧪

Prerequisites

  • Go to Databases -> DB cluster details page -> Settings tab
  • Under "Set a Weekly Maintenance Window" section, verify select "day of week" and "time" dropdowns.

Verification steps

  • Dropdowns under "Set a Weekly Maintenance Window" section in DB cluster settings page should work same as before. All the validations should behave the same.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I first load the page and try to select a time, there's a pretty odd UI bug I'm observing on this branch that doesn't happen in prod:

Screen.Recording.2025-11-06.at.2.11.16.PM.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could arguably be a Tech Story since it's not really a change impacting the look/feel or functionality for the user

Copy link
Contributor

@jaalah jaalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the navigation issue, this looks 👍

@grevanak-akamai grevanak-akamai force-pushed the feature/UIE-8943 branch 2 times, most recently from c9b3a25 to 30b2df3 Compare November 20, 2025 13:18
@grevanak-akamai grevanak-akamai changed the title change: [UIE-8943] - Replace dropdowns in Database cluster settings page with CDS select web component Tech story: [UIE-8943] - Replace dropdowns in Database cluster settings page with CDS select web component Nov 20, 2025
@grevanak-akamai
Copy link
Contributor Author

grevanak-akamai commented Nov 20, 2025

When I first load the page and try to select a time, there's a pretty odd UI bug I'm observing on this branch that doesn't happen in prod:

Screen.Recording.2025-11-06.at.2.11.16.PM.mov

I'm not able to replicate this issue in local though I see it in PR preview link. Can you pull the latest code and test it again in local?

@dwiley-akamai
Copy link
Contributor

When I first load the page and try to select a time, there's a pretty odd UI bug I'm observing on this branch that doesn't happen in prod:
Screen.Recording.2025-11-06.at.2.11.16.PM.mov

I'm not able to replicate this issue in local though I see it in PR preview link. Can you pull the latest code and test it again in local?

I am still seeing it locally after pulling the latest code:

Screen.Recording.2025-11-20.at.10.03.55.AM.mov

I'm using the the latest version of Chrome

@bnussman-akamai bnussman-akamai added the DBaaS Relates to Database as a Service label Nov 20, 2025
@grevanak-akamai grevanak-akamai requested review from pmakode-akamai and removed request for jaalah November 24, 2025 11:08
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing the issue (especially when the window's vertical size is reduced).

I think the issue might be caused by the fixed height of the dropdown. This may need to be adjusted based on the viewport height (vh/%)

on Prod (working) on this branch (preview link) on this branch (local)
Image Image Image

Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice any layout issues now across different viewports on the preview link, locally or with MSW enabled. Thanks for fixing this 👍. The updated pnpm-lock.yaml look good as well

@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 2, 2025
@grevanak-akamai grevanak-akamai requested review from jaalah and smans-akamai and removed request for jaalah December 2, 2025 07:17
@grevanak-akamai
Copy link
Contributor Author

When I first load the page and try to select a time, there's a pretty odd UI bug I'm observing on this branch that doesn't happen in prod:
Screen.Recording.2025-11-06.at.2.11.16.PM.mov

I'm not able to replicate this issue in local though I see it in PR preview link. Can you pull the latest code and test it again in local?

I am still seeing it locally after pulling the latest code:

Screen.Recording.2025-11-20.at.10.03.55.AM.mov
I'm using the the latest version of Chrome

@dwiley-akamai please retest now

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes - looks good 👍

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Dec 2, 2025
@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 2, 2025
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue I mentioned previously appears to be resolved 👍🏾

Copy link
Contributor

@smans-akamai smans-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out a few scenarios and didn't see any issues. It looks like the previous navigation issue had also been resolved, so this looks good to me!

@grevanak-akamai grevanak-akamai merged commit df8ff8f into linode:develop Dec 4, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants