change:[UIE-9541] Add MSW crud support for types API by grevanak-akamai · Pull Request #13067 · linode/manager

grevanak-akamai · 2025-11-07T07:09:19Z

Description 📝

Add CRUD support for /types GET API in MSW

Changes 🔄

Implement a CRUD mode type response

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Verification steps

Enable MSW
Set CRUD as preset type and apply the changes

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

Copilot

Pull Request Overview

This PR adds MSW (Mock Service Worker) CRUD support for the /types GET API endpoint by implementing mock data for various Linode plan types. The changes introduce new factory functions for different GPU and dedicated plan types to support more comprehensive testing.

Key Changes:

Added factory functions for GCP dedicated types, GPU types (RTX, Ada, RTX Pro), premium types, and accelerated types
Implemented a new getLinodePlans handler in the CRUD preset to return mock plan data
Refactored existing type mocking to use the new factory functions for consistency

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
packages/utilities/src/factories/linodes.ts	Added new factory functions for GCP dedicated types, GPU variants, premium types, and accelerated types
packages/manager/src/mocks/serverHandlers.ts	Refactored to use new factory functions instead of inline type definitions
packages/manager/src/mocks/presets/crud/linodes.ts	Added `getLinodePlans` import and handler to CRUD preset exports
packages/manager/src/mocks/presets/crud/handlers/linodes/linodes.ts	Implemented `getLinodePlans` handler with comprehensive mock data using new factories

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/utilities/src/factories/linodes.ts

harsh-akamai

PR looks good! Could we add a changeset for manager too?

grevanak-akamai · 2025-11-07T10:51:29Z

PR looks good! Could we add a changeset for manager too?

Done

* change:[UIE-9541] Add MSW crud support for types API * Added changeset: Add MSW crud support for types API * Added changeset: Add MSW crud support for types API

* initial commit * Added changeset: Address oAuth issue with IAM OAuthCallback * fix: [UIE-9456 & UIE-9457] - Typo + expose search filters on /iam/roles route (#13034) * UIE-9456 & UIE-9457 * test * Added changeset: Typo + expose search filters on /iam/roles route * feat: [UIE-9481] - IAM: add perm check for the drawer (#13043) * feat: [UIE-9481] - IAM: add perm check for the drawer * Added changeset: IAM: add a permission check for delete nodebalancer drawer * feat: [UIE-9503] - add empty state to Default Roles/Entities tab (#13042) * feat: add empty state to Default Roles/Entities table * Added changeset: IAM: Empty state for the Default Roles and Default Entities Access tabs * update text * add unit tests * review fix * unit test fix * fix: [UIE-9478] - IAM: disable tag edit (#13046) * fix: [UIE-9478] - IAM: disable tag edit * Added changeset: IAM: tags editing was enabled for restricted users * fix: [UIE-9478] - add tooltip, disable manage tags in Volume action menu * style fix * Cloud version 1.154.0, API v4 version 0.152.0, Validation version 0.78.0, UI version 0.23.0 * Cloud version 1.154.0, API v4 version 0.152.0, Validation version 0.78.0, UI version 0.23.0 * fix: [M3-10698] - Update linode/clone endpoint and label calculations for < 1 hour (#13045) * fix: [M3-9498] - Update linode/clone endpoint and label calculations for < 1 hour * Add changelogs --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * fix: [UIE-9520] - IAM Child Account - user not found error handling (#13047) * try/cath child user query * consistent handling * types * Added changeset: IAM Child Account - user not found error handling * fix: [UIE-9477] - IAM: disable delete and detach popups for Volumes when user has no permissions (#13049) * fix: [UIE-9477] - IAM: Disable delete and detach popups for Volumes if no permissions * Added changeset: IAM: restricted users could access delete and detach popups without permissions * upcoming: [UIE-9434] - Create feature flag for generational compute plans (#13054) * upcoming: [UIE-9434] - Create feature flag for generational compute plans * Added changeset: Feature flag for Generational Compute plans * test: [DPS-34825] Add cypress tests for Create/Edit Stream forms and Streams Landing (#13008) * refactor: [DI-27807] - Change status of edit & delete button in alert list table based on status (#13052) * refactor: [DI-27807] - Change status of edit & delete button in alert list table based on status * Added comment * Added changeset * refactor: [DI-27807] - Updated test cases * upcoming: [UIE-9368] - Create a firewall Rulesets & Preflixlists feature flag (#13051) * Add firewall rs & pl feature flag * Added changeset: Feature flag for Firewall Rulesets & Prefixlists * feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpcs (#13050) * UIE-9342 * UIE-9341 * feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpc * Added changeset: IAM: fix permissiom's check for vpc for assigning/unassigning linodes * filter linodes * e2e deferred getLinodes call --------- Co-authored-by: Alban Bailly <abailly@akamai.com> * refactor: [UIE-9325] - Replace Formik with React Hook Form in AddAccessControlDrawer (#13044) ## Description 📝 Refactor Database Manage Networking drawer to use React Hook Form instead of Formik ## Changes 🔄 - There should be no visual external changes other than IP validation on blur instead of after clicking Update Access Controls ## How to test 🧪 ### Prerequisites (How to setup test environment) - Have the Database VPC feature flag enabled ### Verification steps (How to verify changes) - [ ] Test adding/editing IPs in the Database landing page via Manage Access Controls action dropdown - [ ] Test adding/editing IPs in the Database details page via the Networking tab - [ ] There should be no regressions compared to prod, error messages should display * [UIE-9533] -Hopeful fix: Race condition with Preferences overrides in PrimaryNav (#13056) * attempt to rule out any race condition * comments * code and fixes * cleanup * Added changeset: Race condition with Preferences overrides in PrimaryNav * feat: [UIE-9393] - IAM Parent/Child: delegate permissions for child account (#13033) * feat: [UIE-9393] - IAM Parent/Child: delegate permissions for child account * changesets * remove the unrestricted check for query * fix conflict * e2e gating * lint fix * better approach to fixing e2e * Mock IAM to be disabled in Account Switching test --------- Co-authored-by: Alban Bailly <abailly@akamai.com> Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com> Co-authored-by: Joe D'Amore <jdamore@akamai.com> * feat: [UIE-9534] - IAM: fix perm for nodebalancer (#13058) * feat: [UIE-9534] - IAM: add tooltips * Added changeset: IAM: add tooltips for disabled buttons for nodebalancers, remove notification banner * update text * remove tooltip * change:[UIE-9541] Add MSW crud support for types API (#13067) * change:[UIE-9541] Add MSW crud support for types API * Added changeset: Add MSW crud support for types API * Added changeset: Add MSW crud support for types API --------- Co-authored-by: aaleksee-akamai <aaleksee@akamai.com> Co-authored-by: mpolotsk-akamai <157619599+mpolotsk-akamai@users.noreply.github.com> Co-authored-by: Dajahi Wiley <dwiley@linode.com> Co-authored-by: Jaalah Ramos <125309814+jaalah-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: grevanak-akamai <145482092+grevanak-akamai@users.noreply.github.com> Co-authored-by: mduda-akamai <mduda@akamai.com> Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com> Co-authored-by: Purvesh Makode <pmakode@akamai.com> Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> Co-authored-by: Joe D'Amore <jdamore@akamai.com>

change:[UIE-9541] Add MSW crud support for types API

32aef76

grevanak-akamai requested a review from a team as a code owner November 7, 2025 07:09

github-project-automation bot moved this to Review in Cloud Manager Nov 7, 2025

github-project-automation bot added this to Cloud Manager Nov 7, 2025

grevanak-akamai requested review from Copilot and removed request for a team November 7, 2025 07:09

Copilot AI reviewed Nov 7, 2025

View reviewed changes

packages/utilities/src/factories/linodes.ts Show resolved Hide resolved

grevanak-akamai and others added 2 commits November 7, 2025 12:43

Added changeset: Add MSW crud support for types API

717b2e0

Merge branch 'develop' into feature/UIE-9541-gcp-update-mocks

23f9a6f

grevanak-akamai requested review from a team, abailly-akamai, harsh-akamai and pmakode-akamai November 7, 2025 07:15

abailly-akamai approved these changes Nov 7, 2025

View reviewed changes

harsh-akamai approved these changes Nov 7, 2025

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Nov 7, 2025

pmakode-akamai approved these changes Nov 7, 2025

View reviewed changes

pmakode-akamai assigned grevanak-akamai Nov 7, 2025

pmakode-akamai added GCP Generational Compute Plans Approved Multiple approvals and ready to merge! labels Nov 7, 2025

Added changeset: Add MSW crud support for types API

70a8f13

grevanak-akamai closed this Nov 7, 2025

github-project-automation bot moved this from Approved to Merged in Cloud Manager Nov 7, 2025

grevanak-akamai reopened this Nov 7, 2025

Merge branch 'develop' into feature/UIE-9541-gcp-update-mocks

4c25ab5

grevanak-akamai merged commit 8685c35 into linode:develop Nov 7, 2025
32 of 35 checks passed

abailly-akamai mentioned this pull request Nov 13, 2025

Release v1.155.0 - release → staging #13085

Merged

abailly-akamai mentioned this pull request Nov 17, 2025

Release v1.155.0 - staging → master #13101

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change:[UIE-9541] Add MSW crud support for types API#13067

change:[UIE-9541] Add MSW crud support for types API#13067
grevanak-akamai merged 5 commits intolinode:developfrom
grevanak-akamai:feature/UIE-9541-gcp-update-mocks

grevanak-akamai commented Nov 7, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

harsh-akamai left a comment

Uh oh!

grevanak-akamai commented Nov 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

grevanak-akamai commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Scope 🚢

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

harsh-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

grevanak-akamai commented Nov 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

grevanak-akamai commented Nov 7, 2025 •

edited

Loading