fix: [UIE-9495, UIE-9595] - Permissions fixes for admin users on users pages#13074
Merged
abailly-akamai merged 5 commits intolinode:developfrom Nov 12, 2025
Merged
fix: [UIE-9495, UIE-9595] - Permissions fixes for admin users on users pages#13074abailly-akamai merged 5 commits intolinode:developfrom
abailly-akamai merged 5 commits intolinode:developfrom
Conversation
aaleksee-akamai
approved these changes
Nov 10, 2025
Contributor
aaleksee-akamai
left a comment
There was a problem hiding this comment.
Confirm that account_admin can delete users and update username and email
bnussman-akamai
approved these changes
Nov 10, 2025
Collaborator
Cloud Manager UI test results🔺 5 failing tests on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts,cypress/e2e/core/stackscripts/update-stackscripts.spec.ts,cypress/e2e/core/vpc/vpc-details-page.spec.ts,cypress/e2e/core/stackscripts/create-stackscripts.spec.ts" |
|||||||||||||||||||||||||||||
This was referenced Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes a couple permission issues on the IAM user screens.
Despite being an account admin, a admin user isn't getting the
delete_user&update_userpermissions. Those roles are exclusive to being an admin, sois_account_admin(aka unrestricted user) really is the only thing we need to check here (restricted users can't access those screens and don't get any users returned) but I kept the permission checks since we don't want any surprises shall anything change on the API side without our knowledge).This regression happened as a result of https://github.com/linode/manager/pull/13033/files which actually improves the account permission checks.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
11/14/2025
How to test 🧪
Prerequisites
Have an IAM admin account
Reproduction steps
With an unrestricted IAM account
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅