feat: [UIE-9423] - IAM Parent/Child: permissions switch account#13075
Conversation
| const canSwitchBetweenParentOrProxyAccount = isIAMDelegationEnabled | ||
| ? profile?.user_type === 'parent' | ||
| : (profile?.user_type === 'parent' && !isChildAccountAccessRestricted) || | ||
| profile?.user_type === 'proxy'; |
There was a problem hiding this comment.
This may be the right logic but my feeling is that we need to introduce the delegate user here. This will be confirmed once we start using the API, but once a parent switches over to act on an third party child-account, it becomes user_type='delegate' during that session.
Cloud Manager UI test results🔺 4 failing tests on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/stackscripts/update-stackscripts.spec.ts,cypress/e2e/core/firewalls/create-firewall.spec.ts,cypress/e2e/core/stackscripts/create-stackscripts.spec.ts" |
||||||||||||||||||||||||||
mpolotsk-akamai
left a comment
There was a problem hiding this comment.
Everything works as expected. Thanks!
abailly-akamai
left a comment
There was a problem hiding this comment.
Approving while waiting for API. We may want to revisit this (see comments) once we're getting really endpoints but meanwhile logic looks good
makes sense, I'll add a comment to this UIE-9566 since it's related to account switching |
Description 📝
This PR updates the logic to check permissions for switching account
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
11/18
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Custom User Account Permissionspreset to test permissionsReproduction steps
(How to reproduce the issue, if applicable)
iamRbacPrimaryNavChangesflag needs to be off)iamRbacPrimaryNavChangesflag needs to be on)Verification steps
(How to verify changes)
IAM Delegation flag is ON:
account is parent:
create_child_account_tokenpermissioncreate_child_account_tokenpermissionaccount isn't a parent:
IAM Delegation flag is OFF:
account is parent or proxy:
account isn't a parent:
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅