upcoming: [DI-28222] - Scaffolding setup for widget level dimension filters and group by issue fix by venkymano-akamai · Pull Request #13088 · linode/manager

venkymano-akamai · 2025-11-13T11:21:20Z

Description 📝

Add widget dimension filters skeleton setup and fix for the group by for firewall dashboards for linode and nodebalancer.

Changes 🔄

List any change(s) relevant to the reviewer.

Fix groupby issue in global group by due to firewall metric definition having unique metrics for linode and nodebalancer.
Add a skeletal setup for widget dimension filters with icon and drawer and renderer.

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Target release date 🗓️

18-11-2025 in develop

Preview 📷

Before	After


-------
Drawer
-------

How to test 🧪

Login and go to Monitor -> Metrics and switch to mock
In the devtools, feature flag section, inside cloudpulse enable showWidgetDimensionFilters.
To test the group by fix, please see the group by options for both firewall for linode dashboards and firewall for nodebalancer dashboard, you should see different options now.
After selecting all required filters, in. the widgets you will be able to see the filter icon, upon clicking you will be able to see the skeletal drawer structure

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

…sion_filters_skeletal_setup

venkymano-akamai · 2025-11-13T17:29:55Z

packages/manager/src/features/CloudPulse/shared/types.ts

 export type TransformFunctionMap = Record<TransformKey, TransformFunction>;

-export type AssociatedEntityType = 'both' | 'linode' | 'nodebalancer';
+export type AssociatedEntityType = 'linode' | 'nodebalancer';


both is not needed, as there is no usecase for it

ankita-akamai

LGTM!

ankita-akamai · 2025-11-14T04:40:41Z

packages/manager/src/features/CloudPulse/GroupBy/utils.ts

+  const associatedEntityType = getAssociatedEntityType(dashboard.id);
+  return metricDefinition
+    .filter(({ label }) =>
+      associatedEntityType
+        ? label.includes(ASSOCIATED_ENTITY_METRIC_MAP[associatedEntityType])
+        : true
+    )


Can you put a small info comment in the code here?

venkymano-akamai · 2025-11-18T13:07:45Z

@bnussman-akamai / @dwiley-akamai

This PR now has the necessary approvals from the CloudPulse team.
Please see if you require a final review of this change.

If yes, please take a look when you have a moment.
If no, please feel free to merge.

Thanks!

linode-gh-bot · 2025-11-19T09:02:16Z

Cloud Manager UI test results

🔺 25 failing tests on test run #8 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`25 Failing`	`837 Passing`	`11 Skipped`	`81m 45s`

Details

Failing Tests
	Spec	Test
❌	`user-permissions.spec.ts`	Cloud Manager Cypress Tests→User permission management » can toggle full account access
❌	`user-permissions.spec.ts`	Cloud Manager Cypress Tests→User permission management » can update global and specific permissions
❌	`user-permissions.spec.ts`	Cloud Manager Cypress Tests→User permission management » can reset user permissions changes
❌	`user-profile.spec.ts`	Cloud Manager Cypress Tests→User Profile » can change email and username of the active account
❌	`vm-host-maintenance-linode.spec.ts`	Cloud Manager Cypress Tests→Host & VM maintenance notification banner » maintenance notification banner does not display platform maintenance messages
❌	`delete-volume.spec.ts`	Cloud Manager Cypress Tests→volume delete flow » deletes a volume
❌	`attach-volume.spec.ts`	Cloud Manager Cypress Tests→volume attach and detach flows » attaches a volume to a Linode
❌	`restricted-user-billing.spec.ts`	Cloud Manager Cypress Tests→restricted user billing flows » cannot edit billing information as child account
❌	`restricted-user-billing.spec.ts`	Cloud Manager Cypress Tests→restricted user billing flows » can edit billing information as a regular user and as a parent user
❌	`enable-object-storage.spec.ts`	Cloud Manager Cypress Tests→Object Storage enrollment » can cancel Object Storage
❌	`account-login-history.spec.ts`	Cloud Manager Cypress Tests→Account login history » users can view the login history table
❌	`display-settings.spec.ts`	Cloud Manager Cypress Tests→Display Settings » can change username via profile display page
❌	`account-linode-managed.spec.ts`	Cloud Manager Cypress Tests→Account Linode Managed » users can enable Linode Managed
❌	`rebuild-linode.spec.ts`	Cloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Image
❌	`rebuild-linode.spec.ts`	Cloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Community StackScript
❌	`rebuild-linode.spec.ts`	Cloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Account StackScript
❌	`rebuild-linode.spec.ts`	Cloud Manager Cypress Tests→rebuild linode » cannot rebuild a provisioning linode
❌	`rebuild-linode.spec.ts`	Cloud Manager Cypress Tests→rebuild linode » can rebuild a Linode reusing existing user data
❌	`rebuild-linode.spec.ts`	Cloud Manager Cypress Tests→rebuild linode » can rebuild a linode with the GECKO is enabled
❌	`account-cancellation.spec.ts`	Cloud Manager Cypress Tests→Account cancellation » users can cancel account
❌	`account-cancellation.spec.ts`	Cloud Manager Cypress Tests→Parent/Child account cancellation » allows a default account with no active child accounts to close the account
❌	`users-landing-page.spec.ts`	Cloud Manager Cypress Tests→Users landing page » can add users with full access
❌	`users-landing-page.spec.ts`	Cloud Manager Cypress Tests→Users landing page » can add users with restricted access
❌	`users-landing-page.spec.ts`	Cloud Manager Cypress Tests→Users landing page » can delete users
❌	`smoke-billing-activity.spec.ts`	Cloud Manager Cypress Tests→Billing Activity Feed » displays correct timezone for invoice and payment dates

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/account/user-permissions.spec.ts,cypress/e2e/core/account/user-profile.spec.ts,cypress/e2e/core/linodes/vm-host-maintenance-linode.spec.ts,cypress/e2e/core/volumes/delete-volume.spec.ts,cypress/e2e/core/volumes/attach-volume.spec.ts,cypress/e2e/core/billing/restricted-user-billing.spec.ts,cypress/e2e/core/objectStorage/enable-object-storage.spec.ts,cypress/e2e/core/account/account-login-history.spec.ts,cypress/e2e/core/account/display-settings.spec.ts,cypress/e2e/core/account/account-linode-managed.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/account/account-cancellation.spec.ts,cypress/e2e/core/account/users-landing-page.spec.ts,cypress/e2e/core/billing/smoke-billing-activity.spec.ts"

venkymano-akamai · 2025-11-19T09:36:47Z

Hi Team,

Ran the failed tests in local, apart from one spec (rebuild-linode.spec.ts), everything passes, attaching the screenshot of it. Also rebuild-linode.spec.ts is not related to this PR

venkymano-akamai · 2025-11-19T09:38:13Z

Also, merging this since it has enough approvals, it also has a follow up PR. @bnussman-akamai / @dwiley-akamai , please continue to review and if there are any comments , it will be done in the follow up PR

venkymano-akamai added 2 commits November 13, 2025 15:24

upcoming: [DI-28222] - Skeletal setup for widget level dimension filters

efdd937

Merge branch 'develop' of github.com:linode/manager into widget_dimen…

ebef10d

…sion_filters_skeletal_setup

github-project-automation bot moved this to Review in Cloud Manager Nov 13, 2025

github-project-automation bot added this to Cloud Manager Nov 13, 2025

upcoming: [DI-28222] - changeset

75d8b51

venkymano-akamai self-assigned this Nov 13, 2025

venkymano-akamai added Work in Progress Cloud Pulse Cloud Pulse - Dashboards labels Nov 13, 2025

venkymano-akamai added 2 commits November 13, 2025 21:17

upcoming: [DI-28222] - fix types

c78513f

upcoming: [DI-28222] - use slot props

35906db

venkymano-akamai added Ready for Review and removed Work in Progress labels Nov 13, 2025

venkymano-akamai marked this pull request as ready for review November 13, 2025 17:27

venkymano-akamai requested a review from a team as a code owner November 13, 2025 17:27

venkymano-akamai requested review from ankita-akamai, bnussman-akamai, dwiley-akamai and nikhagra-akamai November 13, 2025 17:28

venkymano-akamai commented Nov 13, 2025

View reviewed changes

ankita-akamai approved these changes Nov 14, 2025

View reviewed changes

ankita-akamai reviewed Nov 14, 2025

View reviewed changes

ankita-akamai mentioned this pull request Nov 14, 2025

upcoming: [DI-28227] - Integrating Firewall-nodebalancers to ACLP-Alerting #13089

Merged

16 tasks

upcoming: [DI-28222] - add comments

2108860

venkymano-akamai changed the title ~~upcoming: [DI-28222] - Skeletal setup for widget level dimension filters and group by issue fix~~ upcoming: [DI-28222] - Scaffolding setup for widget level dimension filters and group by issue fix Nov 17, 2025

upcoming: [DI-28222] - Scaffolding changes

94bc233

nikhagra-akamai approved these changes Nov 18, 2025

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Nov 18, 2025

Merge branch 'develop' into widget_dimension_filters_skeletal_setup

ecb4cfb

upcoming: [DI-28222] - Quick changeset updates

8484117

venkymano-akamai merged commit b2a852e into linode:develop Nov 19, 2025
34 of 35 checks passed

github-project-automation bot moved this from Approved to Merged in Cloud Manager Nov 19, 2025

abailly-akamai mentioned this pull request Dec 8, 2025

Release v1.156.0 - release → staging #13180

Merged

dwiley-akamai mentioned this pull request Dec 8, 2025

Release v1.156.0 - staging → master #13181

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [DI-28222] - Scaffolding setup for widget level dimension filters and group by issue fix#13088

upcoming: [DI-28222] - Scaffolding setup for widget level dimension filters and group by issue fix#13088
venkymano-akamai merged 9 commits intolinode:developfrom
venkymano-akamai:widget_dimension_filters_skeletal_setup

venkymano-akamai commented Nov 13, 2025

Uh oh!

venkymano-akamai Nov 13, 2025

Uh oh!

ankita-akamai left a comment

Uh oh!

ankita-akamai Nov 14, 2025

Uh oh!

venkymano-akamai commented Nov 18, 2025 •

edited

Loading

Uh oh!

linode-gh-bot commented Nov 19, 2025

Uh oh!

venkymano-akamai commented Nov 19, 2025

Uh oh!

venkymano-akamai commented Nov 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

venkymano-akamai commented Nov 13, 2025

Description 📝

Changes 🔄

Scope 🚢

Target release date 🗓️

Preview 📷

How to test 🧪

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

venkymano-akamai Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

ankita-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

ankita-akamai Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

venkymano-akamai commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linode-gh-bot commented Nov 19, 2025

Cloud Manager UI test results

🔺 25 failing tests on test run #8 ↗︎

Details

Troubleshooting

Uh oh!

venkymano-akamai commented Nov 19, 2025

Uh oh!

venkymano-akamai commented Nov 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

venkymano-akamai commented Nov 18, 2025 •

edited

Loading