Skip to content

fix: [UIE-9656] - Plans panel pagination bug fix#13100

Merged
tvijay-akamai merged 2 commits intolinode:developfrom
tvijay-akamai:feature/UIE-9656
Nov 18, 2025
Merged

fix: [UIE-9656] - Plans panel pagination bug fix#13100
tvijay-akamai merged 2 commits intolinode:developfrom
tvijay-akamai:feature/UIE-9656

Conversation

@tvijay-akamai
Copy link
Contributor

Description 📝

Plans panel pagination bug fix

Changes 🔄

Plans panel page size should not effect the PAGE_SIZE key

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers

Target release date 🗓️

03/12/2025

How to test 🧪

  • Go to linodes, Linodes table should have more then 15 and less then 25 records.
  • Go to create linode, change page size in plans table, come back to linodes table, all the records should be visible

Verification steps

(How to verify changes)

  • Go to linodes, Linodes table should have more then 15 and less then 25 records.
  • Go to create linode, change page size in plans table, come back to linodes table, all the records should be visible
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jdamore-linode jdamore-linode changed the title fix: [UIE-9659] Plans panel pagination bug fix fix: [UIE-9656] - Plans panel pagination bug fix Nov 17, 2025
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @tvijay-akamai, confirmed that this fixes the issue 👍

If you make any last minute tweaks before merging this, feel free to move it to Testing in Jira and I'd be happy to take a second look, but otherwise I think we're good to mark this as Done once this is merged 🚀

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Nov 17, 2025
@pmakode-akamai
Copy link
Contributor

@tvijay-akamai We should add a changeset for this PR if this fix is not going to be included in the upcoming release.

@abailly-akamai
Copy link
Contributor

abailly-akamai commented Nov 17, 2025

@jdamore-linode @tvijay-akamai we do need to point this to the release branch:
#13085

EDIT: i was wrong, since there is a feature flag

@pmakode-akamai pmakode-akamai added Missing Changeset Approved Multiple approvals and ready to merge! labels Nov 17, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing861 Passing11 Skipped41m 33s

Details

Failing Tests
SpecTest
firewall-landing-page.spec.tsCloud Manager Cypress Tests→confirms Firewalls landing page empty state is shown when no Firewalls exist » lists all Firewalls

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/firewalls/firewall-landing-page.spec.ts"

@tvijay-akamai tvijay-akamai merged commit 0888fb0 into linode:develop Nov 18, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants