Skip to content

upcoming: [DI-28270] - Remove firewall filtering and region filter dependency#13111

Merged
ankita-akamai merged 5 commits intolinode:developfrom
ankita-akamai:feature/remove_filtering_firewalls
Nov 24, 2025
Merged

upcoming: [DI-28270] - Remove firewall filtering and region filter dependency#13111
ankita-akamai merged 5 commits intolinode:developfrom
ankita-akamai:feature/remove_filtering_firewalls

Conversation

@ankita-akamai
Copy link
Contributor

@ankita-akamai ankita-akamai commented Nov 20, 2025

Description 📝

Remove firewall filtering and region filter dependency in Firewalls.

Changes 🔄

  • Update filterConfig.ts to remove linode-region and nodebalancer-region filter dependency on firewall/firewalls select.
  • Update filterConfig.ts to remove filtering of firewalls visible in firewall-select based on associated entity types, e.g. linode/nodebalancer.
  • Update CloudPulseRegionSelect.tsx to remove region filtering based on firewalls selection.
  • Update test cases.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

16 Dec 2025

Preview 📷

Before After
image image
image image
image image
image image

How to test 🧪

Verification steps

(How to verify changes)

  • Navigate to metrics page under monitor.
  • Select Cloud Firewall for Linode dashboard.
  • Verify that linode-region filter is enabled irrespective of firewall selection.
  • Click on firewalls dropdown, all firewalls in the account will be listed
  • Select a firewall.
  • Click on region dropdown, verify that all aclp supported regions are visible.
    Note: Regions whose region Obj in /regions api call has monitors: ['Cloud Firewall'] capability are considered aclp supported.
  • Select a region.
  • Verify that metrics can be visualized if there is data available.

Now, go to dashboard-select again.

  • Select Cloud Firewall for nodebalancer dashboard.
  • Verify that nodebalancer-region filter is enabled irrespective of firewall selection.
  • Click on firewalls dropdown, all firewalls in the account will be listed
  • Select a firewall.
  • Click on region dropdown, verify that all aclp supported regions are visible.
    Note: Regions whose region Obj in /regions api call has monitors: ['Cloud Firewall'] capability are considered aclp supported.
  • Select a region.
  • Verify that metrics can be visualized if there is data available.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@ankita-akamai ankita-akamai marked this pull request as ready for review November 20, 2025 05:26
@ankita-akamai ankita-akamai requested a review from a team as a code owner November 20, 2025 05:26
@ankita-akamai ankita-akamai self-assigned this Nov 20, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing861 Passing11 Skipped41m 31s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Nov 21, 2025
@ankita-akamai
Copy link
Contributor Author

Merging as the pr has enough approvals and failing test is unrelated.

@ankita-akamai ankita-akamai merged commit 3c9e18f into linode:develop Nov 24, 2025
36 of 42 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants