Skip to content

Conversation

@mpolotsk-akamai
Copy link
Contributor

Description 📝

This PR fixes Create Linode permissions and disable StackScript/Linode selector when user doesn't have create_linode permission.

Changes 🔄

List any change(s) relevant to the reviewer.

  • disable Linode selector when user doesn't have create_linode permission.
  • disable StackScript when user doesn't have create_linode permission.
  • disable "View Code Snippets" button when user doesn't have create_linode permission

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

December 16th

Preview 📷

Before After
Screenshot 2025-11-20 at 3 16 17 PM Screenshot 2025-11-20 at 3 14 49 PM
Screenshot 2025-11-20 at 3 16 06 PM Screenshot 2025-11-20 at 3 14 33 PM
Screenshot 2025-11-20 at 3 15 53 PM Screenshot 2025-11-20 at 3 14 22 PM

How to test 🧪

Prerequisites

(How to setup test environment)

  • use IAM restricted account with only linode_admin role

Verification steps

(How to verify changes)

  • navigate to linodes/create/stackscripts manually
  • verify that StackScripts selector is disabled if the user does not have create_linode permission
  • switch to the Backups tab
  • verify that Linode selector is disabled if the user does not have create_linode permission
  • select Clone Linode tab
  • verify that Linode selector is disabled if the user does not have create_linode permission
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 3 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing859 Passing11 Skipped49m 24s

Details

Failing Tests
SpecTest
rebuild-linode.spec.tsCloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Account StackScript
vpc-details-page.spec.tsCloud Manager Cypress Tests→VPC details page » can create, edit, and delete a subnet from the VPC details page
create-stackscripts.spec.tsCloud Manager Cypress Tests→Create stackscripts » creates a StackScript and deploys a Linode with it

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts,cypress/e2e/core/vpc/vpc-details-page.spec.ts,cypress/e2e/core/stackscripts/create-stackscripts.spec.ts"

@mpolotsk-akamai mpolotsk-akamai marked this pull request as ready for review November 21, 2025 14:01
@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner November 21, 2025 14:01
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Nov 24, 2025
@mpolotsk-akamai mpolotsk-akamai merged commit 855eabe into linode:develop Nov 28, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM (Identity & Access Management) Linodes Dealing with the Linodes section of the app

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants