Skip to content

Conversation

@aaleksee-akamai
Copy link
Contributor

Description 📝

This PR fixes filtering by the entity's type in the Roles table

Changes 🔄

List any change(s) relevant to the reviewer.

  • Update filtering logic

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

December 16th

Preview 📷

Before After
Screen.Recording.2025-11-24.at.1.30.48.PM.mov
Screen.Recording.2025-11-24.at.1.29.46.PM.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • use iam admin account

Reproduction steps

(How to reproduce the issue, if applicable)

  • go to /iam/roles
  • filter roles by entity's type in the select

Verification steps

(How to verify changes)

  • Roles are filtered by entity type and query
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai requested a review from a team as a code owner November 24, 2025 12:35
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing861 Passing11 Skipped39m 49s

Details

Failing Tests
SpecTest
create-stackscripts.spec.tsCloud Manager Cypress Tests→Create stackscripts » creates a StackScript and deploys a Linode with it

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/stackscripts/create-stackscripts.spec.ts"

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! this looks good

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Nov 25, 2025
@aaleksee-akamai aaleksee-akamai merged commit 3fd1215 into linode:develop Nov 26, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants