-
Notifications
You must be signed in to change notification settings - Fork 391
upcoming: [UIE-9564] - Implement Listener Detail - Nodes table #13147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [UIE-9564] - Implement Listener Detail - Nodes table #13147
Conversation
...s/NetworkLoadBalancersDetail/NetworkLoadBalancersListenerDetail/NodesTable/NodesTableRow.tsx
Show resolved
Hide resolved
...cers/NetworkLoadBalancersDetail/NetworkLoadBalancersListenerDetail/NodesTable/NodesTable.tsx
Show resolved
Hide resolved
...cers/NetworkLoadBalancersDetail/NetworkLoadBalancersListenerDetail/NodesTable/NodesTable.tsx
Outdated
Show resolved
Hide resolved
...cers/NetworkLoadBalancersDetail/NetworkLoadBalancersListenerDetail/NodesTable/NodesTable.tsx
Outdated
Show resolved
Hide resolved
...cers/NetworkLoadBalancersDetail/NetworkLoadBalancersListenerDetail/NodesTable/NodesTable.tsx
Outdated
Show resolved
Hide resolved
...cers/NetworkLoadBalancersDetail/NetworkLoadBalancersListenerDetail/NodesTable/NodesTable.tsx
Outdated
Show resolved
Hide resolved
bnussman-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just left some things to keep in mind regarding API filtering
...cers/NetworkLoadBalancersDetail/NetworkLoadBalancersListenerDetail/NodesTable/NodesTable.tsx
Outdated
Show resolved
Hide resolved
| const { filter: searchFilter, error: searchError } = getAPIFilterFromQuery( | ||
| search?.query, | ||
| { | ||
| searchableFieldsWithoutOperator: ['id', 'linode_id', 'address_v6'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we allow users to search by label by default because label is more user-friendly than numerical IDs. Is there a reason we're not doing that here? Looking at the API source code, label looks like it is filterable.
| searchableFieldsWithoutOperator: ['id', 'linode_id', 'address_v6'], | |
| searchableFieldsWithoutOperator: ['id', 'label', 'linode_id', 'address_v6'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we haven't done so already, we should make sure we test this with the real API because X-Filtering can have limitations. If the API doesn't like this query, we may need to simplify this to the following later on
| searchableFieldsWithoutOperator: ['id', 'linode_id', 'address_v6'], | |
| searchableFieldsWithoutOperator: ['label'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API doesn't support filtering on label for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @bnussman-akamai, I have validated filtering with real time data as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
...cers/NetworkLoadBalancersDetail/NetworkLoadBalancersListenerDetail/NodesTable/NodesTable.tsx
Show resolved
Hide resolved
packages/manager/.changeset/pr-13147-upcoming-features-1764592604792.md
Outdated
Show resolved
Hide resolved
...cers/NetworkLoadBalancersDetail/NetworkLoadBalancersListenerDetail/NodesTable/NodesTable.tsx
Show resolved
Hide resolved
| }, | ||
| to: '/netloadbalancers/$id/listeners', | ||
| }); | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On merging with develop we updated this config.
677c8a2 to
fa002a0
Compare
grevanak-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me. Thanks @tanushree-akamai
Cloud Manager UI test results🔺 22 failing tests on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts,cypress/e2e/core/volumes/upgrade-volume.spec.ts,cypress/e2e/core/linodes/linode-config.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/databases/create-database.spec.ts,cypress/e2e/core/volumes/delete-volume.spec.ts,cypress/e2e/core/volumes/attach-volume.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/smoke-create-image.spec.ts,cypress/e2e/core/linodes/resize-linode.spec.ts" |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description 📝
Implement Nodes Table in Network LoadBalancer Listener Detail page
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅