Skip to content

change: [UIE-9701] - Add Back Navigation functionality in Drawer & Integrate the change with PrefixList Drawer#13151

Merged
pmakode-akamai merged 15 commits intolinode:developfrom
harsh-akamai:UIE-9701-add-back-navigation-to-drawer
Dec 11, 2025
Merged

change: [UIE-9701] - Add Back Navigation functionality in Drawer & Integrate the change with PrefixList Drawer#13151
pmakode-akamai merged 15 commits intolinode:developfrom
harsh-akamai:UIE-9701-add-back-navigation-to-drawer

Conversation

@harsh-akamai
Copy link
Contributor

@harsh-akamai harsh-akamai commented Dec 2, 2025

Description 📝

  • Add optional Back Navigation to the Drawer

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Using handleBackNavigation conditionally:

Description Preview
One level Drawer Screenshot 2025-12-11 at 3 45 10 PM
Two level Drawer (with Back Navigation Icon) Screenshot 2025-12-11 at 3 45 37 PM

How to test 🧪

Prerequisites

  • Add the handleNavigation prop to any of the <Drawer /> Component

Verification steps

  • Verify that the handleNavigation event handler works as expected
  • Verify the story added to Storybook
  • Verify the < icon is not visible when isFetching is true.
  • Verify the < icon is visible only on second-level PrefixList Drawers:
    • You can test using real data or by enabling MSW and the "Firewall RuleSets and PrefixList" feature flag with account capabilities
    • Click the Prefix List referenced in the firewall rules table row and verify that a first-level PrefixList drawer does not show the < icon
    • Go to Add Rule Drawer -> select any Prefix List and click "View Details" of the Prefix List, then verify that the < icon is visible in the PrefixList drawer
    • Optional: Go to a Ruleset where a Prefix List is already referenced, click that Prefix List from the Ruleset drawer, and verify that the < icon is visible in the PrefixList drawer.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@harsh-akamai harsh-akamai marked this pull request as ready for review December 3, 2025 08:58
@harsh-akamai harsh-akamai requested a review from a team as a code owner December 3, 2025 08:58
@harsh-akamai harsh-akamai requested review from jaalah-akamai and removed request for a team December 3, 2025 08:58
@harsh-akamai harsh-akamai self-assigned this Dec 3, 2025
@harsh-akamai harsh-akamai changed the title change: [UIE-9701] - Add Back Navigation Icon to Drawer title change: [UIE-9701] - Add Back Navigation functionality to Drawer title Dec 3, 2025
@harsh-akamai harsh-akamai changed the title change: [UIE-9701] - Add Back Navigation functionality to Drawer title change: [UIE-9701] - Add Back Navigation functionality in Drawer Dec 3, 2025
@harsh-akamai harsh-akamai requested a review from a team as a code owner December 3, 2025 08:59
@pmakode-akamai pmakode-akamai added the UX/UI Changes for UI/UX to review label Dec 3, 2025
sx={(theme) => ({
color: theme.palette.text.primary,
padding: 0,
marginRight: theme.spacing(1),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use spacingFunction here

Copy link
Contributor

@tvijay-akamai tvijay-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. One small change needed.

@github-project-automation github-project-automation bot moved this from Review to Changes Requested in Cloud Manager Dec 3, 2025
data-qa-back-navigation
disableRipple
onClick={handleBackNavigation}
size="small"
Copy link
Contributor

@grevanak-akamai grevanak-akamai Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In figma design for prefix list requirement, size for the icon is 24*24. Also it is not looking center aligned with label.

@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in Cloud Manager Dec 10, 2025
@github-project-automation github-project-automation bot moved this from Approved to Changes Requested in Cloud Manager Dec 11, 2025
@pmakode-akamai pmakode-akamai force-pushed the UIE-9701-add-back-navigation-to-drawer branch from 1020ca6 to a4a2d91 Compare December 11, 2025 09:56
@pmakode-akamai pmakode-akamai changed the title change: [UIE-9701] - Add Back Navigation functionality in Drawer change: [UIE-9701] - Add Back Navigation functionality in Drawer & Integrate the change with PrefixList Drawer Dec 11, 2025
@pmakode-akamai pmakode-akamai added the Firewalls Related to Firewalls label Dec 11, 2025
@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in Cloud Manager Dec 11, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 7 failing tests on test run #10 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
7 Failing820 Passing11 Skipped57m 39s

Details

Failing Tests
SpecTest
create-linode.spec.tsCloud Manager Cypress Tests→Create Linode→End-to-end→By plan type » creates a Premium CPU Linode
create-linode-blackwell.spec.tsCloud Manager Cypress Tests→smoketest for Nvidia blackwell GPUs in linodes/create page » disables Blackwells if disabled region selected
create-linode-blackwell.spec.tsCloud Manager Cypress Tests→smoketest for Nvidia blackwell GPUs in linodes/create page » enables Blackwells if enabled region selected
lke-create.spec.tsCloud Manager Cypress Tests→smoketest for Nvidia Blackwell GPUs in kubernetes/create page→standard tier » enabled feature flag includes blackwells
plan-selection.spec.tsCloud Manager Cypress Tests→displays specific linode plans for GPU » Should render divided tables when GPU divider enabled
plan-selection.spec.tsCloud Manager Cypress Tests→displays specific kubernetes plans for GPU » Should render divided tables when GPU divider enabled
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/create-linode.spec.ts,cypress/e2e/core/linodes/create-linode-blackwell.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/linodes/plan-selection.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts"

@pmakode-akamai pmakode-akamai added the Approved Multiple approvals and ready to merge! label Dec 11, 2025
@pmakode-akamai pmakode-akamai merged commit 39c8d72 into linode:develop Dec 11, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Firewalls Related to Firewalls UX/UI Changes for UI/UX to review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants