upcoming: [UIE-9762] - UX/UI enhancements for RuleSets and Prefix Lists#13165
Merged
pmakode-akamai merged 21 commits intolinode:developfrom Dec 8, 2025
Merged
Conversation
pmakode-akamai
commented
Dec 4, 2025
| })} | ||
| > | ||
| <StyledLabel | ||
| <Stack gap={2} marginTop={1}> |
Contributor
Author
There was a problem hiding this comment.
Just added a Stack for these 2 Papers and only removed marginTop: theme.spacingFunction(8), from each
| </Link> | ||
| )} | ||
| </Box> | ||
| <Hidden smDown={!!rulesetDetails}> |
Contributor
Author
There was a problem hiding this comment.
Hidden is no longer needed for CopyTooltip, since we are making the first column flexible
Comment on lines
+35
to
+39
| autocomplete: { | ||
| "& [data-testid='inputLabelWrapper']": { | ||
| display: 'none', | ||
| }, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
We need to do this to avoid the extra margin that comes from Autocomplete when label="" (the label prop of Autocomplete cannot be null or undefined)
| elements.push(<span key={ip}>{ip}</span>); | ||
| } | ||
| }); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Just moved from below to above to display the addresses in the correct order (IPs should come before PLs)
dwiley-akamai
approved these changes
Dec 4, 2025
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Code review ✅
Verification steps ✅
pmakode-akamai
added
Add'tl Approval Needed
grevanak-akamai
approved these changes
Dec 5, 2025
pmakode-akamai
force-pushed
the
UIE-9762-ux-ui-enhancments-rs-pl-part-1
branch
from
5f3b7c9 to
2cf9a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
UX/UI enhancements for RuleSets and Prefix Lists (part- 1)
Changes 🔄
arrowfrom the tooltip (for addresses) to keep it consistent with how it appears elsewhere in CM, aside from the new scrolling functionality we addedScope 🚢
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
Firewall Rulesets and PrefixListsfeature flagVerification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅